Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ofCubeMapShaders.h not included by default, member function naming typo #8396

Closed
danomatika opened this issue Mar 26, 2025 · 4 comments
Closed

Comments

@danomatika
Copy link
Contributor

From checking ofxLua with the of_v20250319_osx_release nightly:

A question, should gl/ofCubeMapShaders.h be included anywhere? Currently, it is not included through ofMain and only included by its implementation file. Is this an oversight?

I know this as I told SWIG to read the header to generate wrappers however the class is then undefined upon building since the header is not included by default.

@danomatika danomatika changed the title ofCubeMapShaders.h not included by default, is this on purpose? ofCubeMapShaders.h not included by default, member function naming typo Mar 26, 2025
@danomatika
Copy link
Contributor Author

Also, there appears to be a typo: static class function irriadianceCubeMap() should probably be irradianceCubeMap().

@danomatika
Copy link
Contributor Author

Ah, on second look, ofCubeMapShaders.h seems to be a global storage class for ofCubeMap.h and is included only ofCubeMapShader.cpp.

@NickHardeman
Copy link
Contributor

This PR addresses the typo #8399, so maybe this can be closed?

@danomatika
Copy link
Contributor Author

Yes thanks. Sorry for not making the PR myself. I found a bunch of things and realized my fork is a bit out of sync ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants