Skip to content

Commit 89779a1

Browse files
committed
[jsscripting] Restructure & Comment POM
Signed-off-by: Florian Hotze <[email protected]>
1 parent b8c04ae commit 89779a1

File tree

1 file changed

+11
-8
lines changed
  • bundles/org.openhab.automation.jsscripting

1 file changed

+11
-8
lines changed

bundles/org.openhab.automation.jsscripting/pom.xml

+11-8
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
</execution>
4545
</executions>
4646
</plugin>
47+
<!-- bundle the openhab-js library -->
4748
<plugin>
4849
<groupId>com.github.eirslett</groupId>
4950
<artifactId>frontend-maven-plugin</artifactId>
@@ -114,6 +115,7 @@
114115
</execution>
115116
</executions>
116117
</plugin>
118+
<!-- run SAT -->
117119
<plugin>
118120
<groupId>org.openhab.tools.sat</groupId>
119121
<artifactId>sat-plugin</artifactId>
@@ -125,32 +127,33 @@
125127
</build>
126128

127129
<dependencies>
130+
<dependency>
131+
<groupId>org.graalvm.sdk</groupId>
132+
<artifactId>graal-sdk</artifactId>
133+
<version>${graal.version}</version>
134+
</dependency>
128135
<dependency>
129136
<groupId>org.graalvm.truffle</groupId>
130137
<artifactId>truffle-api</artifactId>
131138
<version>${graal.version}</version>
132139
</dependency>
140+
<!-- Graal JavaScript ScriptEngine JSR 223 support -->
133141
<dependency>
134142
<groupId>org.graalvm.js</groupId>
135143
<artifactId>js-scriptengine</artifactId>
136144
<version>${graal.version}</version>
137145
</dependency>
138-
<dependency>
139-
<groupId>org.graalvm.sdk</groupId>
140-
<artifactId>graal-sdk</artifactId>
141-
<version>${graal.version}</version>
142-
</dependency>
146+
<!-- Graal TRegex engine (internally used by Graal JavaScript engine) -->
143147
<dependency>
144148
<groupId>org.graalvm.regex</groupId>
145149
<artifactId>regex</artifactId>
146150
<version>${graal.version}</version>
147151
</dependency>
148-
<dependency> <!-- this must come AFTER the regex lib -->
152+
<!-- Graal JavaScript engine -->
153+
<dependency>
149154
<groupId>org.graalvm.js</groupId>
150155
<artifactId>js</artifactId>
151156
<version>${graal.version}</version>
152157
</dependency>
153-
<!-- GraalJS changelog says that com.ibm.icu/icu4j is not required for GraalJS >= 22.0.0 as it moved to org.graalvm.truffle;
154-
but GraalJS >= 22.2.0 requires it, so we'll need to add it when we upgrade -->
155158
</dependencies>
156159
</project>

0 commit comments

Comments
 (0)