-
-
Notifications
You must be signed in to change notification settings - Fork 720
[developer-documentation] Add description of tools and utilities #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewfg
wants to merge
4
commits into
openhab:main
Choose a base branch
from
andrewfg:utils
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+215
−6
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What advantages offer the standard property types, like
Thing.PROPERTY_SERIAL_NUMBER? A disadvantage is that the property names are not translated depending on the Regional Settings or Browsers preferences.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is documenting existing functionality. Only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR recommends to use the property names defined in the Thing interface, like Thing.PROPERTY_SERIAL_NUMBER. It does not just state that the Thing interface has some constants, the PR recommends using these constants.
So what advantage has using
Thing.PROPERTY_SERIAL_NUMBERover some other string, which is translated by the binding, depending on user preferences?I suggest removing the
## Thing Propertiessection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties are not supposed to be translated. In that way they are similar to channel ids. These system-wide global property names make it easy for example to create a list of current firmware versions for all devices. Or maybe for a widget to show specific device model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not open a separate issue to discuss that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Channel ids are fixed, but the description of the channels can be translated, I do not think this is similar. The user is supposed to see the property names and property values (like “Has Bluetooth module: YES”), so in my eyes the property names should be translated. Theoretically this will not prevent the creation of a list of firmware versions of all devices in openHAB, just the user should see instead of “Firmware“ or “Serial Number” as property name translated text.
Besides in the openHAB documentation I am not aware of text discouraging the internationalization/localization of property names and values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be camelCase, this is documented here: https://www.openhab.org/docs/developer/bindings/thing-xml.html#properties
From a technical discovery perspective, properties and configuration parameters are both provided as properties in camelCase and can also be defined statically in Thing XML definition. The I18N tool does not make these available for translation.
As @andrewfg proposed, please create an issue for continuing this discussion.