review feedback

Signed-off-by: Mark Herwege <[email protected]>

Author: mherwege

README.md

@@ -553,7 +553,9 @@ Calling `Item.persistence` returns an `ItemPersistence` object with the followin
   - .varianceUntil(timestamp, serviceId) ⇒ `PersistedState | null`
   - .varianceBetween(begin, end, serviceId) ⇒ `PersistedState | null`
 
-`riemannType` is an optional argument for methods that require calculating an approximation of the integral value. The approximation is calculated using a Riemann sum, with left, right, trapezoidal or midpoint value approximations. The argument is a Java RiemannType enum with possible values: `RiemannType.LEFT`, `RiemannType.RIGHT`, `RiemannType.TRAPEZOIDAL` or `RiemannType.MIDPOINT`. If ommitted, `RiemannType.LEFT` is used.
+`riemannType` is an optional argument for methods that require calculating an approximation of the integral value.
+The approximation is calculated using a Riemann sum, with left, right, trapezoidal or midpoint value approximations.
+The argument is a Java RiemannType enum with possible values: `RiemannType.LEFT`, `RiemannType.RIGHT`, `RiemannType.TRAPEZOIDAL` or `RiemannType.MIDPOINT`. If ommitted, `RiemannType.LEFT` is used.
 
 Note: `serviceId` is optional, if omitted, the default persistence service will be used.
 

src/items/item-persistence.js

@@ -6,7 +6,7 @@ const { _toOpenhabPrimitiveType, _isTimeSeries } = require('../helpers');
 const PersistenceExtensions = Java.type('org.openhab.core.persistence.extensions.PersistenceExtensions');
 const TimeSeries = Java.type('org.openhab.core.types.TimeSeries');
 const TypeParser = Java.type('org.openhab.core.types.TypeParser');
-const RiemannType = Java.type('org.openhab..core.persistence.extensions.PersistenceExtensions.RiemannType');
+const RiemannType = Java.type('org.openhab.core.persistence.extensions.PersistenceExtensions.RiemannType');
 
 /**
  * @typedef {import('@js-joda/core').ZonedDateTime} time.ZonedDateTime
@@ -655,12 +655,12 @@ class ItemPersistence {
   }
 
   /**
-   * Gets the RiemannSum of the states of a given Item since a certain point in time, time is calculated in seconds.
+   * Gets the Riemann sum of the states of a given Item since a certain point in time, time is calculated in seconds.
    *
    * @example
    * var yesterday = time.toZDT().minusDays(1);
-   * var item = items.getItem('KitchenDimmer');
-   * console.log('KitchenDimmer Riemann sum since yesterday', item.persistence.riemannSumSince(yesterday));
+   * var item = items.getItem('SolarPower');
+   * console.log('Solar energy production since yesterday', item.persistence.riemannSumSince(yesterday));
    *
    * @param {(time.ZonedDateTime | Date)} timestamp the point in time from which to search for the Riemann sum
    * @param {RiemannType} [riemannType] optional Riemann approximation type to calculate the integral approximation
@@ -674,7 +674,7 @@ class ItemPersistence {
   }
 
   /**
-  * Gets the RiemannSum of the states of a given Item until a certain point in time, time is calculated in seconds.
+  * Gets the Riemann sum of the states of a given Item until a certain point in time, time is calculated in seconds.
   *
   * @param {(time.ZonedDateTime | Date)} timestamp the point in time to which to search for the Riemann sum
   * @param {RiemannType} [riemannType] optional Riemann approximation type to calculate the integral approximation
@@ -688,7 +688,7 @@ class ItemPersistence {
   }
 
   /**
-  * Gets the RiemannSum of the states of a given Item between two certain points in time, time is calculated in seconds.
+  * Gets the Riemann sum of the states of a given Item between two certain points in time, time is calculated in seconds.
   *
   * @param {(time.ZonedDateTime | Date)} begin the point in time from which to start the Riemann sum
   * @param {(time.ZonedDateTime | Date)} end the point in time to which to start the Riemann sum