Skip to content

Allow passing the box vectors in CFConvNeighbors #114

@RaulPPelaez

Description

@RaulPPelaez

The underlying CFConv implementation supports PBC, but CFConvNeighbors just hardcodes the box vectors as null.

impl->build(positions.data_ptr<float>(), nullptr);

@raimis I believe you wrote this, do you remember why it was decided not to include the box vectors here?
I am trying to add PBC to TorchMD-Net and stumbled upon this while trying to port the optimized GN there, which uses NNPOps components.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions