Add few more recipe packages

Author: macsux

.nuke/build.schema.json

@@ -33,6 +33,7 @@
         "CreateGithubRelease",
         "DownloadTestFixtures",
         "GenerateRoslynRecipes",
+        "GithubRelease",
         "GradleAssemble",
         "GradleAssembleAndTest",
         "GradleBuild",
@@ -101,6 +102,7 @@
         "PublishServer",
         "Restore",
         "SetDefaultModule",
+        "SignalIfTestcaseOutputExists",
         "StopServer",
         "Test"
       ]
@@ -184,6 +186,10 @@
             "Release"
           ]
         },
+        "GitHubToken": {
+          "type": "string",
+          "description": "GitHub personal access token with access to the repo"
+        },
         "Module": {
           "type": "string",
           "description": "Target Module"

Rewrite/src/Rewrite.MSBuild/RecipieAssemblyResolver.cs renamed to Rewrite/src/Rewrite.MSBuild/RecipeAssemblyResolver.cs

@@ -1,18 +1,20 @@
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Runtime.Loader;
+using NMica.Utils.IO;
 
 namespace Rewrite.MSBuild;
 
-public class RecipieAssemblyResolver : MetadataAssemblyResolver
+public class RecipeAssemblyResolver : MetadataAssemblyResolver
 {
     private PathAssemblyResolver _resolver;
-    public RecipieAssemblyResolver()
+    public RecipeAssemblyResolver(IEnumerable<AbsolutePath> additionalAssemblies)
     {
 
         var runtimeAssemblies = Directory.GetFiles(RuntimeEnvironment.GetRuntimeDirectory(), "*.dll");
         var currentDirAssemblies = Directory.EnumerateFiles(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)!, "*.dll");
-        var allAssemblies = runtimeAssemblies.Union(currentDirAssemblies);
+        var allAssemblies = runtimeAssemblies.Union(currentDirAssemblies).Union(additionalAssemblies.Select(x => (string)x));
+        
         _resolver = new PathAssemblyResolver(allAssemblies);
     }
 

Rewrite/src/Rewrite.MSBuild/RecipeExecutionContext.cs

@@ -161,7 +161,7 @@ private List<RecipeDescriptor> FindRecipesInAssemblies()
         // var currentDirAssemblies = Directory.EnumerateFiles(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)!, "*.dll");
         // var allAssemblies = runtimeAssemblies.Union(currentDirAssemblies);
         // var resolver = new PathAssemblyResolver(runtimeAssemblies);
-        var resolver = new RecipieAssemblyResolver();
+        var resolver = new RecipeAssemblyResolver(_assemblies.Values);
         using var mlc = new MetadataLoadContext(resolver);
         var mlcRecipeAttributeAssembly = mlc.LoadFromAssemblyPath(typeof(RecipesAttribute).Assembly.Location);
         var mlcRecipeAttributeType = mlcRecipeAttributeAssembly.GetType(typeof(RecipesAttribute).FullName!)!;
@@ -200,10 +200,11 @@ private List<RecipeDescriptor> FindRecipesInAssemblies()
 
 
         var analyzerRecipes = metadataAssemblies
-            .SelectMany(x => x.ExportedTypes)
+            .SelectMany(x => x.DefinedTypes)
             .Where(type => type.GetCustomAttributesData().Any(attr => attr.AttributeType == mlcDiagnosticAnalyzerAttributeType))
             .Select(x =>
             {
+                
                 var assembly = LoadFromAssemblyPath(x.Assembly.Location);
                 _recipeAssemblies.Add(assembly);
                 return assembly.GetType(x.FullName!)!;
@@ -226,7 +227,7 @@ private List<RecipeDescriptor> FindRecipesInAssemblies()
 
 
         var fixersById = metadataAssemblies
-            .SelectMany(x => x.ExportedTypes)
+            .SelectMany(x => x.DefinedTypes)
             .Where(type => type.GetCustomAttributesData().Any(attr => attr.AttributeType == mlcCodeFixupAttributeType))
             .Select(x =>
             {

Rewrite/src/Rewrite.MSBuild/RecipeManager.cs

@@ -62,7 +62,18 @@ public async Task<RecipePackageInfo> InstallRecipePackage(
             packageSources: packageSources, 
             cancellationToken: cancellationToken);
     }
-    
+    public async Task<RecipePackageInfo> InstallRecipePackage(
+        string packageId,
+        bool includePrerelease = false,
+        List<PackageSource>? packageSources = null,
+        CancellationToken cancellationToken = default)
+    {
+        return await InstallRecipePackage(
+            new LibraryRange(packageId), 
+            includePrerelease,
+            packageSources, 
+            cancellationToken);
+    }
     public async Task<RecipePackageInfo> InstallRecipePackage(
         string packageId,
         string packageVersion,
@@ -318,7 +329,7 @@ private async Task<LockFile> RestoreProject(PackageSpec packageSpec, CachingSour
                 if(targetFolder is null)
                     return [];
                 var targetFilesRegex = new Regex($"^{targetFolder}.+");
-                var files =  lib.Files.Where(x => targetFilesRegex.IsMatch(x));
+                var files =  lib.Files.Where(x => targetFilesRegex.IsMatch(x) & x.EndsWith(".dll"));
 
                 return files.Select(file => (Folder: lib.Path, File: file, PackageIdentity: new PackageIdentity(lib.Name, lib.Version)));
             })

Rewrite/tests/Rewrite.MSBuild.Tests/ReportingTests.cs

@@ -0,0 +1,44 @@
+using System.Diagnostics.CodeAnalysis;
+using NuGet.Configuration;
+using Rewrite.Core;
+using Serilog;
+
+namespace Rewrite.MSBuild.Tests;
+
+public class ReportingTests :  BaseTests
+{
+    [Test]
+    [Explicit]
+    public async Task RecipePackageAnalysisReport()
+    {
+        Log.Logger = new LoggerConfiguration().CreateLogger();
+
+        var recipeManager = CreateObject<RecipeManager>();
+        string[] feeds =
+        [
+            "https://api.nuget.org/v3/index.json"
+        ];
+        
+        var packageSources = feeds.Select(x => new PackageSource(x)).ToList();
+        var packages =  new []
+        {
+            "Microsoft.CodeAnalysis.NetAnalyzers", //https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/categories
+            "Roslynator.Analyzers", //https://github.com/dotnet/roslynator
+            "Meziantou.Analyzer", //https://github.com/meziantou/Meziantou.Analyzer
+            "StyleCop.Analyzers",
+            // "SonarAnalyzer.CSharp", 
+            // "AsyncFixer", 
+            // "ErrorProne.NET.CoreAnalyzers",
+            "WpfAnalyzers",
+        };
+        var totalRecipes = 0;
+        foreach (var nugetPackage in packages)
+        {
+            var packageInfo = await recipeManager.InstallRecipePackage(nugetPackage, includePrerelease: false);
+            totalRecipes += packageInfo.Recipes.Count;
+            Console.WriteLine($"{packageInfo.Package}: {packageInfo.Recipes.Count}");
+        }
+        Console.WriteLine($"Total: {totalRecipes}");
+
+    }
+}

_build/Build.cs

@@ -307,6 +307,8 @@ grep dotnet |
                 ("Microsoft.CodeAnalysis.NetAnalyzers", "9.0.0"), //https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/categories
                 ("Roslynator.Analyzers", "4.13.1"), //https://github.com/dotnet/roslynator
                 ("Meziantou.Analyzer", "2.0.201"), //https://github.com/meziantou/Meziantou.Analyzer
+                ("StyleCop.Analyzers", "1.1.118"), //https://github.com/DotNetAnalyzers/StyleCopAnalyzers/tree/master
+                ("WpfAnalyzers", "4.1.1"),
             };
 
             var installablePackages = await Task.WhenAll(packages.Select(x => recipeManager.InstallRecipePackage(x.Package, x.Version, packageSources: packageSources)));
@@ -545,6 +547,7 @@ GradleSettings ApplyCommonGradleSettings(GradleSettings options) => options
     Target GithubRelease => _ => _
         .Description("Creates a GitHub release (or amends existing)")
         .Requires(() => GitHubToken)
+        .After(Pack, NugetPush, GradlePublish, Test, GradleAssembleAndTest, GradleTest)
         .Executes(async () =>
         {
             await CreateGitHubRelease($"v{Version.SemVer1}");