Skip to content

Commit 6ba16cc

Browse files
timtebeektimtebeek
committed
Apply OpenRewrite best practices to silence review bot
1 parent 61ed4bc commit 6ba16cc

File tree

1 file changed

+74
-72
lines changed

1 file changed

+74
-72
lines changed

‎src/test/java/org/openrewrite/java/migrate/maven/UpdateMavenProjectPropertyJavaVersionTest.java‎

Lines changed: 74 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -38,42 +38,42 @@ void basic() {
3838
rewriteRun(
3939
//language=xml
4040
pomXml(
41-
"""
42-
<project>
43-
<groupId>com.example</groupId>
44-
<artifactId>foo</artifactId>
45-
<version>1.0.0</version>
46-
<modelVersion>4.0</modelVersion>
47-
<properties>
48-
<java.version>11</java.version>
49-
<jdk.version>11</jdk.version>
50-
<javaVersion>11</javaVersion>
51-
<jdkVersion>11</jdkVersion>
52-
<maven.compiler.source>11</maven.compiler.source>
53-
<maven.compiler.target>11</maven.compiler.target>
54-
<maven.compiler.release>11</maven.compiler.release>
55-
<release.version>11</release.version>
56-
</properties>
57-
</project>
58-
""",
5941
"""
60-
<project>
61-
<groupId>com.example</groupId>
62-
<artifactId>foo</artifactId>
63-
<version>1.0.0</version>
64-
<modelVersion>4.0</modelVersion>
65-
<properties>
66-
<java.version>17</java.version>
67-
<jdk.version>17</jdk.version>
68-
<javaVersion>17</javaVersion>
69-
<jdkVersion>17</jdkVersion>
70-
<maven.compiler.source>17</maven.compiler.source>
71-
<maven.compiler.target>17</maven.compiler.target>
72-
<maven.compiler.release>17</maven.compiler.release>
73-
<release.version>17</release.version>
74-
</properties>
75-
</project>
76-
""")
42+
<project>
43+
<groupId>com.example</groupId>
44+
<artifactId>foo</artifactId>
45+
<version>1.0.0</version>
46+
<modelVersion>4.0</modelVersion>
47+
<properties>
48+
<java.version>11</java.version>
49+
<jdk.version>11</jdk.version>
50+
<javaVersion>11</javaVersion>
51+
<jdkVersion>11</jdkVersion>
52+
<maven.compiler.source>11</maven.compiler.source>
53+
<maven.compiler.target>11</maven.compiler.target>
54+
<maven.compiler.release>11</maven.compiler.release>
55+
<release.version>11</release.version>
56+
</properties>
57+
</project>
58+
""",
59+
"""
60+
<project>
61+
<groupId>com.example</groupId>
62+
<artifactId>foo</artifactId>
63+
<version>1.0.0</version>
64+
<modelVersion>4.0</modelVersion>
65+
<properties>
66+
<java.version>17</java.version>
67+
<jdk.version>17</jdk.version>
68+
<javaVersion>17</javaVersion>
69+
<jdkVersion>17</jdkVersion>
70+
<maven.compiler.source>17</maven.compiler.source>
71+
<maven.compiler.target>17</maven.compiler.target>
72+
<maven.compiler.release>17</maven.compiler.release>
73+
<release.version>17</release.version>
74+
</properties>
75+
</project>
76+
""")
7777
);
7878
}
7979

@@ -82,24 +82,24 @@ void bringsDownExplicitlyUsedPropertyFromRemoteParent() {
8282
rewriteRun(
8383
//language=xml
8484
pomXml(
85-
"""
86-
<project>
87-
<groupId>com.example</groupId>
88-
<artifactId>example-parent</artifactId>
89-
<version>1.0.0</version>
90-
<modelVersion>4.0</modelVersion>
91-
<properties>
92-
<java.version>11</java.version>
93-
<jdk.version>11</jdk.version>
94-
<javaVersion>11</javaVersion>
95-
<jdkVersion>11</jdkVersion>
96-
<maven.compiler.source>11</maven.compiler.source>
97-
<maven.compiler.target>11</maven.compiler.target>
98-
<maven.compiler.release>11</maven.compiler.release>
99-
<release.version>11</release.version>
100-
</properties>
101-
</project>
102-
""",
85+
"""
86+
<project>
87+
<groupId>com.example</groupId>
88+
<artifactId>example-parent</artifactId>
89+
<version>1.0.0</version>
90+
<modelVersion>4.0</modelVersion>
91+
<properties>
92+
<java.version>11</java.version>
93+
<jdk.version>11</jdk.version>
94+
<javaVersion>11</javaVersion>
95+
<jdkVersion>11</jdkVersion>
96+
<maven.compiler.source>11</maven.compiler.source>
97+
<maven.compiler.target>11</maven.compiler.target>
98+
<maven.compiler.release>11</maven.compiler.release>
99+
<release.version>11</release.version>
100+
</properties>
101+
</project>
102+
""",
103103
SourceSpec::skip),
104104
mavenProject("example-child",
105105
//language=xml
@@ -130,7 +130,7 @@ void bringsDownExplicitlyUsedPropertyFromRemoteParent() {
130130
</build>
131131
</project>
132132
""",
133-
"""
133+
"""
134134
<project>
135135
<parent>
136136
<groupId>com.example</groupId>
@@ -169,25 +169,27 @@ void bringsDownExplicitlyUsedPropertyFromRemoteParent() {
169169
void addReleaseIfNoOtherChangeIsMade() {
170170
rewriteRun(
171171
//language=xml
172-
pomXml("""
173-
<project>
174-
<groupId>com.example</groupId>
175-
<artifactId>example-child</artifactId>
176-
<version>1.0.0</version>
177-
<modelVersion>4.0</modelVersion>
178-
</project>
179-
""",
172+
pomXml(
180173
"""
181-
<project>
182-
<groupId>com.example</groupId>
183-
<artifactId>example-child</artifactId>
184-
<version>1.0.0</version>
185-
<modelVersion>4.0</modelVersion>
186-
<properties>
187-
<maven.compiler.release>17</maven.compiler.release>
188-
</properties>
189-
</project>
190-
""")
174+
<project>
175+
<groupId>com.example</groupId>
176+
<artifactId>example-child</artifactId>
177+
<version>1.0.0</version>
178+
<modelVersion>4.0</modelVersion>
179+
</project>
180+
""",
181+
"""
182+
<project>
183+
<groupId>com.example</groupId>
184+
<artifactId>example-child</artifactId>
185+
<version>1.0.0</version>
186+
<modelVersion>4.0</modelVersion>
187+
<properties>
188+
<maven.compiler.release>17</maven.compiler.release>
189+
</properties>
190+
</project>
191+
"""
192+
)
191193
);
192194
}
193195
}

0 commit comments

Comments
 (0)