-
Notifications
You must be signed in to change notification settings - Fork 103
Change the Jetty dependency coordinates going from EE9 to EE10 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the help here @ChenyuWang98 ! When comparing the Java EE 9 and 10 recipes I noticed that we're matching the "old" identifiers before the Java EE 9 upgrade in the EE 10 upgrade, but those will already have been changed, since Java EE 10 first runs
|
| oldGroupId: org.eclipse.jetty.websocket | ||
| oldArtifactId: websocket-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below I think we should expect the ee9 specific dependencies and change those to ee10.
| oldGroupId: org.eclipse.jetty.websocket | |
| oldArtifactId: websocket-server | |
| oldGroupId: org.eclipse.jetty.ee9.websocket | |
| oldArtifactId: jetty-ee9-websocket-jetty-server |
|
Let me know if you're ok to make those adjustments; otherwise we can try to pick this up on our side. |
|
I think there's no problem. My only wish is that Jetty be upgraded to EE10 concurrently with the Jakarta EE10 upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made the suggested changes to fix the test. Thanks for flagging this omission!

What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist