Skip to content

Conversation

@ChenyuWang98
Copy link
Contributor

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Oct 28, 2025
@timtebeek
Copy link
Member

Thanks for the help here @ChenyuWang98 ! When comparing the Java EE 9 and 10 recipes I noticed that we're matching the "old" identifiers before the Java EE 9 upgrade in the EE 10 upgrade, but those will already have been changed, since Java EE 10 first runs org.openrewrite.java.migrate.jakarta.JavaxMigrationToJakarta, which includes org.openrewrite.java.migrate.jakarta.JettyUpgradeEE9.

image

Comment on lines 538 to 539
oldGroupId: org.eclipse.jetty.websocket
oldArtifactId: websocket-server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below I think we should expect the ee9 specific dependencies and change those to ee10.

Suggested change
oldGroupId: org.eclipse.jetty.websocket
oldArtifactId: websocket-server
oldGroupId: org.eclipse.jetty.ee9.websocket
oldArtifactId: jetty-ee9-websocket-jetty-server

@timtebeek
Copy link
Member

Let me know if you're ok to make those adjustments; otherwise we can try to pick this up on our side.

@timtebeek timtebeek added enhancement New feature or request recipe Recipe requested labels Oct 28, 2025
@timtebeek timtebeek marked this pull request as draft October 28, 2025 11:02
@ChenyuWang98
Copy link
Contributor Author

I think there's no problem. My only wish is that Jetty be upgraded to EE10 concurrently with the Jakarta EE10 upgrade.

@ChenyuWang98 ChenyuWang98 marked this pull request as ready for review October 29, 2025 01:09
@timtebeek timtebeek changed the title jakartaEE10 adds jetty upgrade logic. Change the Jetty dependency coordinates going from EE9 to EE10 Oct 31, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Oct 31, 2025
Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the suggested changes to fix the test. Thanks for flagging this omission!

@timtebeek timtebeek merged commit 19ba363 into openrewrite:main Oct 31, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request recipe Recipe requested

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants