Read settings.xml from disk if no maven settings are defined for testing framework (#5873)

* Add settings.xml file to the rewrite test run

* Polish

* Polish

* Use settings.xml if no settings is provided for MavenPomDownloader

* Polish

* Polish

* Polish

* Polish

* Polish

* Polish

* Inline `hasNoDefinedConfiguration`

* Explain what we're checking and why we're loading from disk

* Tone down defaulting to pomXml rewrite-tests only

* Put `readFromDiskEnabled` back

* Remove `mavenSettings` from Assertions Gradle file

* Polish

---------

Co-authored-by: Tim te Beek <[email protected]>

Author: jevanlingen

rewrite-maven/src/main/java/org/openrewrite/maven/Assertions.java

@@ -30,14 +30,21 @@
 import java.util.function.Consumer;
 
 import static org.junit.jupiter.api.Assertions.fail;
+import static org.openrewrite.maven.tree.MavenRepository.MAVEN_LOCAL_DEFAULT;
 
 public class Assertions {
     private Assertions() {
     }
 
     static void customizeExecutionContext(ExecutionContext ctx) {
-        if (MavenSettings.readFromDiskEnabled()) {
-            MavenExecutionContextView mctx = MavenExecutionContextView.view(ctx);
+        MavenExecutionContextView mctx = MavenExecutionContextView.view(ctx);
+        boolean nothingConfigured = mctx.getSettings() == null &&
+                                    mctx.getLocalRepository().equals(MAVEN_LOCAL_DEFAULT) &&
+                                    mctx.getRepositories().isEmpty() &&
+                                    mctx.getActiveProfiles().isEmpty() &&
+                                    mctx.getMirrors().isEmpty();
+        if (nothingConfigured) {
+            // Load Maven settings to pick up any mirrors, proxies etc. that might be required in corporate environments
             mctx.setMavenSettings(MavenSettings.readMavenSettingsFromDisk(mctx));
         }
     }

rewrite-maven/src/main/java/org/openrewrite/maven/MavenExecutionContextView.java

@@ -218,6 +218,23 @@ public List<String> getActiveProfiles() {
         return getMessage(MAVEN_ACTIVE_PROFILES, emptyList());
     }
 
+    /**
+     * Replaces the current Maven execution settings with the provided {@link MavenSettings}.
+     * <p>
+     * This method does <strong>not</strong> merge with or preserve any existing configuration.
+     * All previously configured repositories, mirrors, credentials, active profiles,
+     * and local repository settings will be discarded and replaced entirely with those
+     * derived from the given {@code settings}.
+     * </p>
+     *
+     * <p>If {@code settings} is {@code null}, this call is a no-op and the current
+     * configuration remains unchanged.</p>
+     *
+     * @param settings        the Maven settings to apply; if {@code null}, no changes are made
+     * @param activeProfiles  additional active profiles to consider; these are resolved
+     *                        against the provided settings to determine the effective profiles
+     * @return this execution context view with the updated Maven settings applied
+     */
     public MavenExecutionContextView setMavenSettings(@Nullable MavenSettings settings, String... activeProfiles) {
         if (settings == null) {
             return this;

rewrite-maven/src/main/java/org/openrewrite/maven/MavenSettings.java

@@ -150,7 +150,12 @@ void maybeDecryptPasswords(ExecutionContext ctx) {
         }
     }
 
-
+    /**
+     * @deprecated The concept of property `org.openrewrite.test.readMavenSettingsFromDisk` is no longer in use.
+     *
+     * @return True property `org.openrewrite.test.readMavenSettingsFromDisk` is true, false otherwise.
+     */
+    @Deprecated
     public static boolean readFromDiskEnabled() {
         final String propertyValue = System.getProperty("org.openrewrite.test.readMavenSettingsFromDisk");
         return propertyValue != null && !"false".equalsIgnoreCase(propertyValue);