Improve declaring type information for Kotlin top-level functions #5934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jevanlingen
force-pushed
the
type-information-top-level-method-invocations
branch
from
e8c58c6 to
54553f5
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jevanlingen
force-pushed
the
type-information-top-level-method-invocations
branch
from
54553f5 to
1636d04
Compare
rewrite-kotlin/src/test/java/org/openrewrite/kotlin/tree/KTSTest.java
Outdated
Show resolved
Hide resolved
…st.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jevanlingen
force-pushed
the
type-information-top-level-method-invocations
branch
from
0bba682 to
53e673a
Compare
jevanlingen
changed the title
jevanlingen
changed the title
jevanlingen
force-pushed
the
type-information-top-level-method-invocations
branch
from
2863991 to
57eda9b
Compare
knutwannheden
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Top-level Kotlin functions now correctly have their declaring type set.
What's your motivation?
Top-level functions in Kotlin do not belong to a class in the FIR frontend, although the backend generates a synthetic JVM class. The previous logic does produce incorrect declaringType values when the top-level function was located in a different file than the method invocation. By handling the case where a function has no enclosing class, we can assign a correct synthetic declaring type based on the file.
This ensures accurate representation of top-level functions in the parser, which is needed for:
Checklist