Skip to content

Commit 92507a2

Browse files
kavillaashwin-pcabbyhu2000
authored
[i18n] fix generation scripts (#4252)
* [i18n] fix generation scripts Gave file permissions to the i18n scripts Generated: opensearch-project/dashboards-i18n#25 With: ``` ./scripts/use_node scripts/i18n_extract.js --output-dir plugins/dashboards-i18n/translations/ ``` Had to fix some issues generating the scripts for example incorrect namespacing. Issue: #867 Signed-off-by: Kawika Avilla <[email protected]> * update snapshot Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]>
1 parent 6bab7ef commit 92507a2

File tree

13 files changed

+28
-16
lines changed

13 files changed

+28
-16
lines changed

.i18nrc.json

+8-2
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,17 @@
6161
"visTypeXy": "src/plugins/vis_type_xy",
6262
"visualizations": "src/plugins/visualizations",
6363
"visualize": "src/plugins/visualize",
64-
"apmOss": "src/plugins/apm_oss",
6564
"usageCollection": "src/plugins/usage_collection"
6665
},
6766
"exclude": [
68-
"src/legacy/ui/ui_render/ui_render_mixin.js"
67+
"src/legacy/ui/ui_render/ui_render_mixin.js",
68+
"src/plugins/home/public/application/components/tutorial",
69+
"src/plugins/home/server/tutorials",
70+
"src/core/server/rendering/views/template.tsx",
71+
"src/plugins/data/public/search/errors/timeout_error.tsx",
72+
"src/plugins/home/public/application/components/welcome.tsx",
73+
"src/plugins/vis_type_timeline/server/series_functions/graphite.js",
74+
"src/plugins/vis_type_timeseries/public/application/components/aggs/serial_diff.js"
6975
],
7076
"translations": []
7177
}

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
9393

9494
### 🐛 Bug Fixes
9595

96+
- [Chore] Update deprecated url methods (url.parse(), url.format()) ([#2910](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2910))
97+
- Cleanup unused url ([#3847](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3847))
98+
- Fix `i18n` generation scripts ([#4252](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4252))
9699
- [Saved Objects Management] Fix relationships header overflow ([#4070](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4070))
97100
- Update main menu to display 'Dashboards' for consistency ([#4453](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4453))
98101
- [Multiple DataSource] Retain the original sample data API ([#4526](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/4526))

scripts/i18n_check.js

100644100755
File mode changed.

scripts/i18n_extract.js

100644100755
File mode changed.

scripts/i18n_integrate.js

100644100755
File mode changed.

src/plugins/dashboard/public/plugin.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ export class DashboardPlugin
356356
createSortText: 'Dashboard',
357357
createLinkText: (
358358
<FormattedMessage
359-
id="opensearch-dashboards-react.tableListView.listing.createNewItemButtonLabel"
359+
id="dashboard.tableListView.listing.createNewItemButtonLabel"
360360
defaultMessage="{entityName}"
361361
values={{ entityName: 'Dashboard' }}
362362
/>

src/plugins/data/common/search/aggs/buckets/date_range_fn.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export const aggDateRange = (): FunctionDefinition => ({
9191
json: {
9292
types: ['string'],
9393
help: i18n.translate('data.search.aggs.buckets.dateRange.json.help', {
94-
defaultMessage: 'Advanced json to include when the agg is sent to Elasticsearch',
94+
defaultMessage: 'Advanced json to include when the agg is sent to OpenSearch',
9595
}),
9696
},
9797
customLabel: {

src/plugins/dev_tools/public/application.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ function DevToolsWrapper({
116116
})
117117
.catch(() => {
118118
toasts.addDanger(
119-
i18n.translate('devTool.devToolWrapper.fetchDataSourceError', {
119+
i18n.translate('devTools.devToolWrapper.fetchDataSourceError', {
120120
defaultMessage: 'Unable to fetch existing data sources',
121121
})
122122
);
@@ -173,10 +173,10 @@ function DevToolsWrapper({
173173
{dataSourceEnabled ? (
174174
<div className="devAppDataSourcePicker">
175175
<EuiComboBox
176-
aria-label={i18n.translate('devTool.devToolWrapper.DataSourceComboBoxAriaLabel', {
176+
aria-label={i18n.translate('devTools.devToolWrapper.DataSourceComboBoxAriaLabel', {
177177
defaultMessage: 'Select a Data Source',
178178
})}
179-
placeholder={i18n.translate('devTool.devToolWrapper.DataSourceComboBoxPlaceholder', {
179+
placeholder={i18n.translate('devTools.devToolWrapper.DataSourceComboBoxPlaceholder', {
180180
defaultMessage: 'Select a Data Source',
181181
})}
182182
singleSelection={{ asPlainText: true }}

src/plugins/expressions/common/expression_functions/specs/opensearch_dashboards.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ export const opensearchDashboards: ExpressionFunctionOpenSearchDashboards = {
4949

5050
inputTypes: ['opensearch_dashboards_context', 'null'],
5151

52-
help: i18n.translate('expressions.functions.kibana.help', {
53-
defaultMessage: 'Gets opensearch dashboards global context',
52+
help: i18n.translate('expressions.functions.opensearchDashboards.help', {
53+
defaultMessage: 'Gets OpenSearch Dashboards global context',
5454
}),
5555

5656
args: {},

src/plugins/opensearch_dashboards_overview/public/components/overview/__snapshots__/overview.test.tsx.snap

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/plugins/opensearch_dashboards_overview/public/components/overview/overview.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features, bran
222222
<h2 id="osdOverviewMore__title">
223223
<FormattedMessage
224224
id="opensearchDashboardsOverview.more.title"
225-
defaultMessage="Do more with Elastic"
225+
defaultMessage="Do more with OpenSearch"
226226
/>
227227
</h2>
228228
</EuiTitle>

src/plugins/telemetry/common/constants.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export const getConfigTelemetryDesc = () => {
4242
// Can't find where it's used but copying it over from the legacy code just in case...
4343
return i18n.translate('telemetry.telemetryConfigDescription', {
4444
defaultMessage:
45-
'Help us improve the OpenSearch Stack by providing usage statistics for basic features. We will not share this data outside of Elastic.',
45+
'Help us improve the OpenSearch Stack by providing usage statistics for basic features. We will not share this data outside of OpenSearch.',
4646
});
4747
};
4848

src/plugins/visualizations/server/plugin.ts

+6-3
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,13 @@ export class VisualizationsPlugin
8383
defaultMessage: 'Disable visualizations bucket aggregation types',
8484
}),
8585
value: [],
86-
description: i18n.translate('visualizations.advancedSettings.visualizeDisableBucketAgg', {
87-
defaultMessage: `A comma-separated list of bucket aggregations' names. e.g. significant_terms, terms.
86+
description: i18n.translate(
87+
'visualizations.advancedSettings.visualizeDisableBucketAgg.description',
88+
{
89+
defaultMessage: `A comma-separated list of bucket aggregations' names. e.g. significant_terms, terms.
8890
Deactivates the specified bucket aggregations from visualizations.`,
89-
}),
91+
}
92+
),
9093
category: ['visualization'],
9194
schema: schema.arrayOf(schema.string()),
9295
},

0 commit comments

Comments
 (0)