Remove lingering certs - Redundant with keystores.

Signed-off-by: Finn Carroll <[email protected]>

Author: finnegancarroll

plugins/transport-grpc/src/test/java/org/opensearch/transport/grpc/SecureNetty4GrpcServerTransportTests.java

@@ -109,8 +109,6 @@ public void testGrpcOptionalAuthTLS() {
             assertEquals(hasNoCertClient.checkHealth(), HealthCheckResponse.ServingStatus.SERVING);
             hasNoCertClient.close();
 
-            // Client with un-trusted cert - TODO
-
             // Client with trusted cert
             NettyGrpcClient hasTrustedCertClient = new NettyGrpcClient.Builder().setAddress(remoteAddress).clientAuth(true).build();
             assertEquals(hasTrustedCertClient.checkHealth(), HealthCheckResponse.ServingStatus.SERVING);
@@ -146,8 +144,6 @@ public void testGrpcRequiredAuthTLS() {
             }
             hasNoCertClient.close();
 
-            // Client with un-trusted cert - TODO
-
             // Client with trusted cert
             NettyGrpcClient hasTrustedCertClient = new NettyGrpcClient.Builder().setAddress(remoteAddress).clientAuth(true).build();
             assertEquals(hasTrustedCertClient.checkHealth(), HealthCheckResponse.ServingStatus.SERVING);

plugins/transport-grpc/src/test/java/org/opensearch/transport/grpc/SecureSettingsHelpers.java

@@ -39,9 +39,7 @@ public class SecureSettingsHelpers {
     private static final String TEST_PASS = "password"; // used for all keystores
 
     static final String SERVER_KEYSTORE = "/netty4-server-secure.jks";
-    static final String SERVER_CERT = "/server.crt";
     static final String CLIENT_KEYSTORE = "/netty4-client-secure.jks";
-    static final String CLIENT_CERT = "/client.crt";
     static final String[] DEFAULT_SSL_PROTOCOLS = { "TLSv1.3", "TLSv1.2", "TLSv1.1" };
     static final String[] DEFAULT_CIPHERS = {
         "TLS_AES_128_GCM_SHA256",