Skip to content

Commit 7c46f8f

Browse files
retamsfrohandrrossexpani
authored
Update to Apache Lucene 10 for 3.0.0 (#16366)
* Update to Apache Lucene 10 for 3.0.0 Signed-off-by: Andriy Redko <[email protected]> * More Lucene 10 build fixes Core compiles now. (Plugins/modules don't yet.) Major areas covered: 1. MultiTermQuery now takes RewriteMethod via constructor instead of setter. 2. Scorable no longer has docId. 3. ScoreCachingWrappingScorer now takes + returns LeafCollector. 4. MMapDirectory allows configuring preload per file (so we don't have to). 5. Concurrent search can now operate at sub-segment level (but we don't yet). Signed-off-by: Michael Froh <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andrew Ross <[email protected]> * Replace DocValuesFieldExistsQuery with FieldExistsQuery Signed-off-by: Andrew Ross <[email protected]> * Fix signature changes in o.a.l.search.BooleanQuery Signed-off-by: Andrew Ross <[email protected]> * Fix more compilation failures, update shadow Gradle plugin and fix loggerUsageCheck Gradle task Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fix analysis-common compilation issues Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * More compilation fixes Signed-off-by: Andrew Ross <[email protected]> * More compilation fixes Signed-off-by: Andrew Ross <[email protected]> * Fix assemble tasks Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures, add CHANGELOG.md Signed-off-by: Andriy Redko <[email protected]> * Fix more compilation failures Signed-off-by: Andriy Redko <[email protected]> * Fixed Lucene latest codec name Signed-off-by: Andriy Redko <[email protected]> * Refactor preload tests in FsDirectoryFactoryTests Also more compilation fixes. Signed-off-by: Andrew Ross <[email protected]> * Fix more compilation failures Signed-off-by: Andrew Ross <[email protected]> * Fix precommit failures Signed-off-by: Andrew Ross <[email protected]> * Fix analysis test cases Signed-off-by: Andriy Redko <[email protected]> * Fix FieldData & ParentJoinAggregator ordinal traversal Signed-off-by: Andriy Redko <[email protected]> * Fix IpFieldMapper & CollapsingDocValuesSource ordinal traversal Signed-off-by: Andriy Redko <[email protected]> * Fix MultiValueMode, GlobalOrdinalValuesSource, BinaryRangeAggregator, DiversifiedOrdinalsSamplerAggregator, GlobalOrdinalsStringTermsAggregator & CardinalityAggregator ordinal traversal Signed-off-by: Andriy Redko <[email protected]> * Fix MultiValueModeTests, BinaryRangeAggregatorTests, IncludeExcludeTests & MissingValuesTests ordinal traversal Signed-off-by: Andriy Redko <[email protected]> * Fix ICUCollationKeywordFieldMapper & VectorFieldTests tests Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.common.xcontent.support.XContentMapValuesTests test cases Signed-off-by: Andriy Redko <[email protected]> * Fix FunctionScoreQuery::CustomBoostFactorWeight::scorerSupplier that may throw NPE Signed-off-by: Andriy Redko <[email protected]> * Fix CodecTests and non-concurrent ContextIndexSearcher::search implementation for aggregations Signed-off-by: Andriy Redko <[email protected]> * Fixed GlobalOrdinalMapping ordinals iteration and SortedWiderNumericSortField implementation of missingValueAsComparableLong Signed-off-by: Andriy Redko <[email protected]> * Fix FieldData and SortedSetDocValuesWriterWrapperTests Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests test cases Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.search.aggregations.bucket.composite.CompositeAggregatorTests test cases Signed-off-by: Andriy Redko <[email protected]> * Fix MultiValueMode ordinal traversal Signed-off-by: Andriy Redko <[email protected]> * Fix GlobalOrdinalMapping and GlobalOrdinalsStringTermsAggregator ordinal traversals Signed-off-by: Andriy Redko <[email protected]> * Fix QueryStringQueryBuilderTests and QueryStringQueryBuilder fuzzy query default rewrite method detection logic Signed-off-by: Andriy Redko <[email protected]> * Fix StarTree*DocValueFormatTests The Composite912DocValuesReader was not honoring the IOContext correctly. The metadata file should be opened with READONCE and immediately be closed (on the same thread). The data file needs to be opened with ReadAdvice.NORMAL to ensure that it's closeable on another thread if necessary. Signed-off-by: Michael Froh <[email protected]> * Fix various MultiTermQuery-related tests Now that we use CONSTANT_SCORE_BLENDED_REWRITE by default for most MTQs, we need to update the tests. Also FuzzyQuery should default to TopTermsBlendedFreqScoringRewrite (taken from Lucene). Signed-off-by: Michael Froh <[email protected]> * Fix Spotless Signed-off-by: Michael Froh <[email protected]> * Fix RegEx automaton processing using Operations.determinize(...) Signed-off-by: Andriy Redko <[email protected]> * Fix compilation issues (post merge) Signed-off-by: Andriy Redko <[email protected]> * Fix UnsignedLongComparator::sortableBytesToLong encoding Signed-off-by: Andriy Redko <[email protected]> * Fix HalfFloatComparator::sortableBytesToLong and HalfFloatComparator::missingValueAsComparableLong Signed-off-by: Andriy Redko <[email protected]> * Fix infinite recursion in CollapsingTopDocsCollectorTests Signed-off-by: Michael Froh <[email protected]> * Fix SingleDimensionValuesSourceTests Can no longer mock IndexReader as it's sealed. Signed-off-by: Michael Froh <[email protected]> * Fix a few more MultiTermQuery-related test failures Signed-off-by: Michael Froh <[email protected]> * Fixed QueryPhaseTests#minScoreOptimisation by not delegating setWeight to underlying delegate Signed-off-by: expani <[email protected]> * Fix DerivedFieldMapperQueryTests Needed to add doc values to date and IP fields. Signed-off-by: Michael Froh <[email protected]> * Fix SortedNumericDocValuesWriterWrapperTests Lucene's SortedNumericDocValuesWriter no longer throws an exception if you try to iterate past a document's last value. (Instead, it happily leaks the next document's value.) Signed-off-by: Michael Froh <[email protected]> * Fix IpRangeAggregatorTests Rewrote a for-loop in BinaryRangeAggregator to be less confusing. As a side-effect, it fixed the test. Signed-off-by: Michael Froh <[email protected]> * Fix IpFieldMapperTests I broke these tests as a side-effect for my fix to DerivedFieldMapperQueryTests. Signed-off-by: Michael Froh <[email protected]> * Fix MissingValues ordinal traversal and MultiOrdinalsTests tests Signed-off-by: Andriy Redko <[email protected]> * Prevent cascading test failures in SearchServiceTests I'm not really fixing the failing tests, but ensuring that the two tests that fail don't cause a bunch of other tests to fail by leaving transient settings around. (Clean up the transient settings even if those tests fail.) Signed-off-by: Michael Froh <[email protected]> * Fix DerivedFieldTypeTests I broke these when fixing DerivedFieldMapperQueryTests. Signed-off-by: Michael Froh <[email protected]> * Fix TransferManagerRemoteDirectoryReaderTests Needed to update mocked calls. Signed-off-by: Michael Froh <[email protected]> * Add missing javadoc Signed-off-by: Andriy Redko <[email protected]> * Uploaded Index generated from Lucene 8.x ( OpenSearch 1.3.0 ) to be used by UnitTests Signed-off-by: expani <[email protected]> * Moved path to a constant Signed-off-by: expani <[email protected]> * Update Apache Lucene to 10.1.0 Signed-off-by: Andriy Redko <[email protected]> * Fixed unit tests for lucene 10 upgrade Signed-off-by: expani <[email protected]> * Fix posting format for CompletionFieldMapper Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.search.SearchServiceTests test cases Signed-off-by: Andriy Redko <[email protected]> * Removed extra iteration of DISI and added stored field option to bypass modified check in lucene Field Signed-off-by: expani <[email protected]> * Changed to use advance and init to use docId() instead of nextDoc() Signed-off-by: expani <[email protected]> * Increased number of indexed docs to match segment count Signed-off-by: expani <[email protected]> * Reduced segment count to match assertion instead of increasing docs Signed-off-by: expani <[email protected]> * Revert to make 90_search_after integ pass as hits are not shown Signed-off-by: expani <[email protected]> * Making Half Float failures work with it's conversions Signed-off-by: expani <[email protected]> * Changing max long to signed from unsigned Signed-off-by: expani <[email protected]> * Addressed PR Comments Signed-off-by: expani <[email protected]> * Trying another approach for gracefully handling unsigned long conversions Signed-off-by: expani <[email protected]> * Simplified unsigned to signed long conversion Signed-off-by: expani <[email protected]> * Reverted changes as need to think more on this Signed-off-by: expani <[email protected]> * Fix azure-fixture & s3-fixture Docker images Signed-off-by: Andriy Redko <[email protected]> * Fix 'search/90_search_after/numeric skipping logic with competitive missing value' test cases Signed-off-by: Andriy Redko <[email protected]> * Fix gcs-fixture Docker images Signed-off-by: Andriy Redko <[email protected]> * Updated to use modern Romanian Unicode Signed-off-by: expani <[email protected]> * Fix org.opensearch.wildfly.WildflyIT test cases Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.search.aggregations.bucket.MinDocCountIT test cases Signed-off-by: Andriy Redko <[email protected]> * Fix CardinalityAggregator.OrdinalsCollector ordinals traversal Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.search.query.ScriptScoreQueryIT test cases Signed-off-by: Andriy Redko <[email protected]> * Fix org.opensearch.search.scriptfilter.ScriptQuerySearchIT test cases Signed-off-by: Andriy Redko <[email protected]> * Fix UnsignedLongComparator top/bottom as comparable long conversions Signed-off-by: Andriy Redko <[email protected]> * Fix post-merge (with main) compilation issues Signed-off-by: Andriy Redko <[email protected]> * Fix UnsignedLongComparator with respect to sortable bytes to long conversion Signed-off-by: Andriy Redko <[email protected]> * Fix FlatObjectFieldTypeTests test cases Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Michael Froh <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Signed-off-by: expani <[email protected]> Co-authored-by: Michael Froh <[email protected]> Co-authored-by: Andrew Ross <[email protected]> Co-authored-by: expani <[email protected]>
1 parent 8a5c3b5 commit 7c46f8f

File tree

519 files changed

+3466
-3050
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

519 files changed

+3466
-3050
lines changed

‎.github/workflows/assemble.yml

+3-14
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ${{ matrix.os }}
88
strategy:
99
matrix:
10-
java: [ 11, 17, 21 ]
10+
java: [ 21, 23 ]
1111
os: [ubuntu-latest, windows-latest, macos-13, ubuntu-24.04-arm]
1212
steps:
1313
- uses: actions/checkout@v4
@@ -16,17 +16,6 @@ jobs:
1616
with:
1717
java-version: ${{ matrix.java }}
1818
distribution: temurin
19-
- name: Set up JDK 17
20-
# See please https://docs.gradle.org/8.10/userguide/upgrading_version_8.html#minimum_daemon_jvm_version
21-
if: matrix.java == 11
22-
uses: actions/setup-java@v4
23-
with:
24-
java-version: 17
25-
distribution: temurin
26-
- name: Set JAVA${{ matrix.java }}_HOME
27-
shell: bash
28-
run: |
29-
echo "JAVA${{ matrix.java }}_HOME=$JAVA_HOME_${{ matrix.java }}_${{ runner.arch }}" >> $GITHUB_ENV
3019
- name: Setup docker (missing on MacOS)
3120
id: setup_docker
3221
if: runner.os == 'macos'
@@ -44,8 +33,8 @@ jobs:
4433
shell: bash
4534
if: runner.os != 'macos'
4635
run: |
47-
./gradlew assemble --parallel --no-build-cache -PDISABLE_BUILD_CACHE -Druntime.java=${{ matrix.java }}
36+
./gradlew assemble --parallel --no-build-cache -PDISABLE_BUILD_CACHE
4837
- name: Run Gradle (assemble)
4938
if: runner.os == 'macos' && steps.setup_docker.outcome == 'success'
5039
run: |
51-
./gradlew assemble --parallel --no-build-cache -PDISABLE_BUILD_CACHE -Druntime.java=${{ matrix.java }}
40+
./gradlew assemble --parallel --no-build-cache -PDISABLE_BUILD_CACHE

‎.github/workflows/precommit.yml

+2-13
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
runs-on: ${{ matrix.os }}
88
strategy:
99
matrix:
10-
java: [ 11, 17, 21, 23 ]
10+
java: [ 21, 23 ]
1111
os: [ubuntu-latest, windows-latest, macos-latest, macos-13, ubuntu-24.04-arm]
1212
steps:
1313
- uses: actions/checkout@v4
@@ -17,18 +17,7 @@ jobs:
1717
java-version: ${{ matrix.java }}
1818
distribution: temurin
1919
cache: gradle
20-
- name: Set up JDK 17
21-
# See please https://docs.gradle.org/8.10/userguide/upgrading_version_8.html#minimum_daemon_jvm_version
22-
if: matrix.java == 11
23-
uses: actions/setup-java@v4
24-
with:
25-
java-version: 17
26-
distribution: temurin
27-
- name: Set JAVA${{ matrix.java }}_HOME
28-
shell: bash
29-
run: |
30-
echo "JAVA${{ matrix.java }}_HOME=$JAVA_HOME_${{ matrix.java }}_${{ runner.arch }}" >> $GITHUB_ENV
3120
- name: Run Gradle (precommit)
3221
shell: bash
3322
run: |
34-
./gradlew javadoc precommit --parallel -Druntime.java=${{ matrix.java }}
23+
./gradlew javadoc precommit --parallel

‎CHANGELOG-3.0.md

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
1515
- Views, simplify data access and manipulation by providing a virtual layer over one or more indices ([#11957](https://github.com/opensearch-project/OpenSearch/pull/11957))
1616

1717
### Dependencies
18+
- Update Apache Lucene to 10.1.0 ([#16366](https://github.com/opensearch-project/OpenSearch/pull/16366))
1819
- Bump Apache HttpCore5/HttpClient5 dependencies from 5.2.5/5.3.1 to 5.3.1/5.4.1 to support ExtendedSocketOption in HttpAsyncClient ([#16757](https://github.com/opensearch-project/OpenSearch/pull/16757))
1920

2021
### Changed

‎benchmarks/build.gradle

+2-41
Original file line numberDiff line numberDiff line change
@@ -85,44 +85,5 @@ spotless {
8585
}
8686
}
8787

88-
if (BuildParams.runtimeJavaVersion >= JavaVersion.VERSION_20) {
89-
// Add support for incubator modules on supported Java versions.
90-
run.jvmArgs += ['--add-modules=jdk.incubator.vector']
91-
run.classpath += files(jar.archiveFile)
92-
run.classpath -= sourceSets.main.output
93-
evaluationDependsOn(':libs:opensearch-common')
94-
95-
sourceSets {
96-
java20 {
97-
java {
98-
srcDirs = ['src/main/java20']
99-
}
100-
}
101-
}
102-
103-
configurations {
104-
java20Implementation.extendsFrom(implementation)
105-
}
106-
107-
dependencies {
108-
java20Implementation sourceSets.main.output
109-
java20Implementation project(':libs:opensearch-common').sourceSets.java20.output
110-
java20AnnotationProcessor "org.openjdk.jmh:jmh-generator-annprocess:$versions.jmh"
111-
}
112-
113-
compileJava20Java {
114-
targetCompatibility = JavaVersion.VERSION_20
115-
options.compilerArgs.addAll(["-processor", "org.openjdk.jmh.generators.BenchmarkProcessor"])
116-
}
117-
118-
jar {
119-
metaInf {
120-
into 'versions/20'
121-
from sourceSets.java20.output
122-
}
123-
manifest.attributes('Multi-Release': 'true')
124-
}
125-
126-
// classes generated by JMH can use all sorts of forbidden APIs but we have no influence at all and cannot exclude these classes
127-
disableTasks('forbiddenApisJava20')
128-
}
88+
// Add support for incubator modules on supported Java versions.
89+
run.jvmArgs += ['--add-modules=jdk.incubator.vector']

‎benchmarks/src/main/java/org/opensearch/common/round/RoundableSupplier.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
public class RoundableSupplier implements Supplier<Roundable> {
1414
private final Supplier<Roundable> delegate;
1515

16-
RoundableSupplier(String type, long[] values, int size) throws ClassNotFoundException {
16+
RoundableSupplier(String type, long[] values, int size) {
1717
switch (type) {
1818
case "binary":
1919
delegate = () -> new BinarySearcher(values, size);
@@ -22,7 +22,8 @@ public class RoundableSupplier implements Supplier<Roundable> {
2222
delegate = () -> new BidirectionalLinearSearcher(values, size);
2323
break;
2424
case "btree":
25-
throw new ClassNotFoundException("BtreeSearcher is not supported below JDK 20");
25+
delegate = () -> new BtreeSearcher(values, size);
26+
break;
2627
default:
2728
throw new IllegalArgumentException("invalid type: " + type);
2829
}

‎buildSrc/build.gradle

+5-5
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ processResources {
7474
* Java version *
7575
*****************************************************************************/
7676

77-
if (JavaVersion.current() < JavaVersion.VERSION_11) {
78-
throw new GradleException('At least Java 11 is required to build opensearch gradle tools')
77+
if (JavaVersion.current() < JavaVersion.VERSION_21) {
78+
throw new GradleException('At least Java 21 is required to build opensearch gradle tools')
7979
}
8080

8181
sourceSets {
@@ -111,7 +111,7 @@ dependencies {
111111
api 'org.apache.rat:apache-rat:0.15'
112112
api "commons-io:commons-io:${props.getProperty('commonsio')}"
113113
api "net.java.dev.jna:jna:5.14.0"
114-
api 'com.github.johnrengelman:shadow:8.1.1'
114+
api 'com.gradleup.shadow:shadow-gradle-plugin:8.3.5'
115115
api 'org.jdom:jdom2:2.0.6.1'
116116
api "org.jetbrains.kotlin:kotlin-stdlib-jdk8:${props.getProperty('kotlin')}"
117117
api 'de.thetaphi:forbiddenapis:3.8'
@@ -171,8 +171,8 @@ if (project != rootProject) {
171171

172172
allprojects {
173173
java {
174-
targetCompatibility = JavaVersion.VERSION_11
175-
sourceCompatibility = JavaVersion.VERSION_11
174+
targetCompatibility = JavaVersion.VERSION_21
175+
sourceCompatibility = JavaVersion.VERSION_21
176176
}
177177
}
178178

‎buildSrc/reaper/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
apply plugin: 'java'
1313

1414
java {
15-
targetCompatibility = JavaVersion.VERSION_11
16-
sourceCompatibility = JavaVersion.VERSION_11
15+
targetCompatibility = JavaVersion.VERSION_21
16+
sourceCompatibility = JavaVersion.VERSION_21
1717
}
1818

1919
jar {

‎buildSrc/src/integTest/resources/org/opensearch/gradle/internal/fake_git/remote/.ci/java-versions.properties

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@
2727
# specific language governing permissions and limitations
2828
# under the License.
2929
#
30-
OPENSEARCH_BUILD_JAVA=openjdk11
31-
OPENSEARCH_RUNTIME_JAVA=java11
30+
OPENSEARCH_BUILD_JAVA=openjdk21
31+
OPENSEARCH_RUNTIME_JAVA=java21
3232
GRADLE_TASK=build

‎buildSrc/src/main/resources/forbidden/opensearch-server-signatures.txt

-4
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,6 @@ java.nio.channels.FileChannel#read(java.nio.ByteBuffer, long)
6161
@defaultMessage Use Lucene.parseLenient instead it strips off minor version
6262
org.apache.lucene.util.Version#parseLeniently(java.lang.String)
6363

64-
@defaultMessage Spawns a new thread which is solely under lucenes control use ThreadPool#relativeTimeInMillis instead
65-
org.apache.lucene.search.TimeLimitingCollector#getGlobalTimerThread()
66-
org.apache.lucene.search.TimeLimitingCollector#getGlobalCounter()
67-
6864
@defaultMessage Don't interrupt threads use FutureUtils#cancel(Future<T>) instead
6965
java.util.concurrent.Future#cancel(boolean)
7066

‎buildSrc/src/main/resources/minimumCompilerVersion

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
17
1+
21

‎buildSrc/src/main/resources/minimumRuntimeVersion

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
11
1+
21

‎buildSrc/src/testKit/thirdPartyAudit/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ dependencies {
4646
}
4747

4848
tasks.register("empty", ThirdPartyAuditTask) {
49-
targetCompatibility = JavaVersion.VERSION_11
49+
targetCompatibility = JavaVersion.VERSION_21
5050
signatureFile = file('third-party-audit-empty.txt')
5151
}
5252

5353
tasks.register("absurd", ThirdPartyAuditTask) {
54-
targetCompatibility = JavaVersion.VERSION_11
54+
targetCompatibility = JavaVersion.VERSION_21
5555
signatureFile = file('third-party-audit-absurd.txt')
5656
}

‎client/rest-high-level/src/test/java/org/opensearch/client/HighLevelRestClientCompressionIT.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public void testCompressesResponseIfRequested() throws IOException {
6767
SearchResponse searchResponse = execute(searchRequest, highLevelClient()::search, highLevelClient()::searchAsync, requestOptions);
6868

6969
assertThat(searchResponse.status().getStatus(), equalTo(200));
70-
assertEquals(1L, searchResponse.getHits().getTotalHits().value);
70+
assertEquals(1L, searchResponse.getHits().getTotalHits().value());
7171
assertEquals(SAMPLE_DOCUMENT, searchResponse.getHits().getHits()[0].getSourceAsString());
7272
}
7373

‎client/rest-high-level/src/test/java/org/opensearch/client/ReindexIT.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ public void testDeleteByQuery() throws Exception {
236236
assertEquals(0, bulkResponse.getSearchFailures().size());
237237
assertEquals(
238238
2,
239-
highLevelClient().search(new SearchRequest(sourceIndex), RequestOptions.DEFAULT).getHits().getTotalHits().value
239+
highLevelClient().search(new SearchRequest(sourceIndex), RequestOptions.DEFAULT).getHits().getTotalHits().value()
240240
);
241241
}
242242
{

‎client/rest-high-level/src/test/java/org/opensearch/client/RestHighLevelClientTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ public void testSearchScroll() throws IOException {
237237
RequestOptions.DEFAULT
238238
);
239239
assertEquals(mockSearchResponse.getScrollId(), searchResponse.getScrollId());
240-
assertEquals(0, searchResponse.getHits().getTotalHits().value);
240+
assertEquals(0, searchResponse.getHits().getTotalHits().value());
241241
assertEquals(5, searchResponse.getTotalShards());
242242
assertEquals(5, searchResponse.getSuccessfulShards());
243243
assertEquals(100, searchResponse.getTook().getMillis());

0 commit comments

Comments
 (0)