Skip to content

Commit b64bdc7

Browse files
committed
Don't create repository in local node factory apply if using stream transport
Signed-off-by: bowenlan-amzn <[email protected]>
1 parent 97881bc commit b64bdc7

File tree

1 file changed

+8
-2
lines changed
  • server/src/main/java/org/opensearch/node

1 file changed

+8
-2
lines changed

server/src/main/java/org/opensearch/node/Node.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1292,7 +1292,7 @@ protected Node(final Environment initialEnvironment, Collection<PluginInfo> clas
12921292
streamTransport,
12931293
threadPool,
12941294
networkModule.getTransportInterceptor(),
1295-
new LocalNodeFactory(settings, nodeEnvironment.nodeId(), remoteStoreNodeService),
1295+
new LocalNodeFactory(settings, nodeEnvironment.nodeId(), remoteStoreNodeService, true),
12961296
settingsModule.getClusterSettings(),
12971297
transportService.getTaskManager(),
12981298
transportService.getRemoteClusterService(),
@@ -2325,11 +2325,17 @@ private static class LocalNodeFactory implements Function<BoundTransportAddress,
23252325
private final String persistentNodeId;
23262326
private final Settings settings;
23272327
private final RemoteStoreNodeService remoteStoreNodeService;
2328+
private final boolean useStreamTransport;
23282329

23292330
private LocalNodeFactory(Settings settings, String persistentNodeId, RemoteStoreNodeService remoteStoreNodeService) {
2331+
this(settings, persistentNodeId, remoteStoreNodeService, false);
2332+
}
2333+
2334+
private LocalNodeFactory(Settings settings, String persistentNodeId, RemoteStoreNodeService remoteStoreNodeService, boolean useStreamTransport) {
23302335
this.persistentNodeId = persistentNodeId;
23312336
this.settings = settings;
23322337
this.remoteStoreNodeService = remoteStoreNodeService;
2338+
this.useStreamTransport = useStreamTransport;
23332339
}
23342340

23352341
@Override
@@ -2340,7 +2346,7 @@ public DiscoveryNode apply(BoundTransportAddress boundTransportAddress) {
23402346
persistentNodeId
23412347
);
23422348

2343-
if (isRemoteStoreAttributePresent(settings)) {
2349+
if (!useStreamTransport && isRemoteStoreAttributePresent(settings)) {
23442350
remoteStoreNodeService.createAndVerifyRepositories(discoveryNode);
23452351
}
23462352

0 commit comments

Comments
 (0)