Use pack method for half_float and usigned_long (#19553)

* use pack methods

Signed-off-by: Prudhvi Godithi <[email protected]>

* update changelog

Signed-off-by: Prudhvi Godithi <[email protected]>

* update changelog

Signed-off-by: Prudhvi Godithi <[email protected]>

* Remove array creation

Signed-off-by: Prudhvi Godithi <[email protected]>

* Fix changelog

Signed-off-by: Prudhvi Godithi <[email protected]>

---------

Signed-off-by: Prudhvi Godithi <[email protected]>

Author: prudhvigodithi

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased 3.x]
 ### Added
+- Use Lucene `pack` method for `half_float` and `usigned_long` when using `ApproximatePointRangeQuery`.
 
 ### Changed
 - Refactor to move prepareIndex and prepareDelete methods to Engine class ([#19551](https://github.com/opensearch-project/OpenSearch/pull/19551))

server/src/main/java/org/opensearch/index/mapper/NumberFieldMapper.java

@@ -405,8 +405,8 @@ public Query rangeQuery(
                         query,
                         new ApproximatePointRangeQuery(
                             field,
-                            NumberType.HALF_FLOAT.encodePoint(l),
-                            NumberType.HALF_FLOAT.encodePoint(u),
+                            HalfFloatPoint.pack(l).bytes,
+                            HalfFloatPoint.pack(u).bytes,
                             APPROX_QUERY_NUMERIC_DIMS,
                             ApproximatePointRangeQuery.HALF_FLOAT_FORMAT
                         )
@@ -604,8 +604,8 @@ public Query rangeQuery(
                         query,
                         new ApproximatePointRangeQuery(
                             field,
-                            FloatPoint.pack(new float[] { l }).bytes,
-                            FloatPoint.pack(new float[] { u }).bytes,
+                            FloatPoint.pack(l).bytes,
+                            FloatPoint.pack(u).bytes,
                             APPROX_QUERY_NUMERIC_DIMS,
                             ApproximatePointRangeQuery.FLOAT_FORMAT
                         )
@@ -778,8 +778,8 @@ public Query rangeQuery(
                             query,
                             new ApproximatePointRangeQuery(
                                 field,
-                                DoublePoint.pack(new double[] { l }).bytes,
-                                DoublePoint.pack(new double[] { u }).bytes,
+                                DoublePoint.pack(l).bytes,
+                                DoublePoint.pack(u).bytes,
                                 APPROX_QUERY_NUMERIC_DIMS,
                                 ApproximatePointRangeQuery.DOUBLE_FORMAT
                             )
@@ -1228,8 +1228,8 @@ public Query rangeQuery(
                         query,
                         new ApproximatePointRangeQuery(
                             field,
-                            IntPoint.pack(new int[] { l }).bytes,
-                            IntPoint.pack(new int[] { u }).bytes,
+                            IntPoint.pack(l).bytes,
+                            IntPoint.pack(u).bytes,
                             APPROX_QUERY_NUMERIC_DIMS,
                             ApproximatePointRangeQuery.INT_FORMAT
                         )
@@ -1396,8 +1396,8 @@ public Query rangeQuery(
                             query,
                             new ApproximatePointRangeQuery(
                                 field,
-                                LongPoint.pack(new long[] { l }).bytes,
-                                LongPoint.pack(new long[] { u }).bytes,
+                                LongPoint.pack(l).bytes,
+                                LongPoint.pack(u).bytes,
                                 APPROX_QUERY_NUMERIC_DIMS,
                                 ApproximatePointRangeQuery.LONG_FORMAT
                             )
@@ -1555,8 +1555,8 @@ public Query rangeQuery(
                             query,
                             new ApproximatePointRangeQuery(
                                 field,
-                                NumberType.UNSIGNED_LONG.encodePoint(l),
-                                NumberType.UNSIGNED_LONG.encodePoint(u),
+                                BigIntegerPoint.pack(l).bytes,
+                                BigIntegerPoint.pack(u).bytes,
                                 APPROX_QUERY_NUMERIC_DIMS,
                                 ApproximatePointRangeQuery.UNSIGNED_LONG_FORMAT
                             )