Spotless apply

Signed-off-by: Finn Carroll <carrofin@amazon.com>

Author: finnegancarroll

plugins/arrow-flight-rpc/src/test/java/org/opensearch/arrow/flight/bootstrap/FlightClientManagerTests.java

@@ -54,13 +54,13 @@
 import io.netty.util.NettyRuntime;
 
 import static org.opensearch.arrow.flight.bootstrap.FlightClientManager.LOCATION_TIMEOUT_MS;
+import static org.opensearch.common.util.FeatureFlags.ARROW_STREAMS_SETTING;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.doAnswer;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.reset;
 import static org.mockito.Mockito.when;
-import static org.opensearch.common.util.FeatureFlags.ARROW_STREAMS_SETTING;
 
 @SuppressWarnings("unchecked")
 public class FlightClientManagerTests extends OpenSearchTestCase {

plugins/arrow-flight-rpc/src/test/java/org/opensearch/arrow/flight/bootstrap/FlightServiceTests.java

@@ -31,9 +31,9 @@
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.atomic.AtomicInteger;
 
+import static org.opensearch.common.util.FeatureFlags.ARROW_STREAMS_SETTING;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
-import static org.opensearch.common.util.FeatureFlags.ARROW_STREAMS_SETTING;
 
 public class FlightServiceTests extends OpenSearchTestCase {
 

server/src/main/java/org/opensearch/common/util/FeatureFlags.java

@@ -141,19 +141,21 @@ public class FeatureFlags {
     public static final Setting<Boolean> ARROW_STREAMS_SETTING = Setting.boolSetting(ARROW_STREAMS, false, Property.NodeScope);
 
     // mutable for testing
-    private static final ArrayList<Setting<Boolean>> ALL_FEATURE_FLAG_SETTINGS = new ArrayList<>(List.of(
-        REMOTE_STORE_MIGRATION_EXPERIMENTAL_SETTING,
-        EXTENSIONS_SETTING,
-        TELEMETRY_SETTING,
-        DATETIME_FORMATTER_CACHING_SETTING,
-        TIERED_REMOTE_INDEX_SETTING,
-        PLUGGABLE_CACHE_SETTING,
-        STAR_TREE_INDEX_SETTING,
-        APPLICATION_BASED_CONFIGURATION_TEMPLATES_SETTING,
-        READER_WRITER_SPLIT_EXPERIMENTAL_SETTING,
-        TERM_VERSION_PRECOMMIT_ENABLE_SETTING,
-        ARROW_STREAMS_SETTING
-    ));
+    private static final ArrayList<Setting<Boolean>> ALL_FEATURE_FLAG_SETTINGS = new ArrayList<>(
+        List.of(
+            REMOTE_STORE_MIGRATION_EXPERIMENTAL_SETTING,
+            EXTENSIONS_SETTING,
+            TELEMETRY_SETTING,
+            DATETIME_FORMATTER_CACHING_SETTING,
+            TIERED_REMOTE_INDEX_SETTING,
+            PLUGGABLE_CACHE_SETTING,
+            STAR_TREE_INDEX_SETTING,
+            APPLICATION_BASED_CONFIGURATION_TEMPLATES_SETTING,
+            READER_WRITER_SPLIT_EXPERIMENTAL_SETTING,
+            TERM_VERSION_PRECOMMIT_ENABLE_SETTING,
+            ARROW_STREAMS_SETTING
+        )
+    );
 
     /**
      * Underlying implementation for feature flags.

server/src/test/java/org/opensearch/cluster/applicationtemplates/SystemTemplatesServiceTests.java

@@ -23,8 +23,8 @@
 import org.mockito.Mockito;
 
 import static org.opensearch.common.settings.ClusterSettings.BUILT_IN_CLUSTER_SETTINGS;
-import static org.mockito.Mockito.when;
 import static org.opensearch.common.util.FeatureFlags.APPLICATION_BASED_CONFIGURATION_TEMPLATES;
+import static org.mockito.Mockito.when;
 
 public class SystemTemplatesServiceTests extends OpenSearchTestCase {
 

server/src/test/java/org/opensearch/cluster/metadata/MetadataIndexTemplateServiceTests.java

@@ -2752,9 +2752,6 @@ protected boolean resetNodeAfterTest() {
 
     @Override
     protected Settings featureFlagSettings() {
-        return Settings.builder()
-            .put(super.featureFlagSettings())
-            .put(APPLICATION_BASED_CONFIGURATION_TEMPLATES, false)
-            .build();
+        return Settings.builder().put(super.featureFlagSettings()).put(APPLICATION_BASED_CONFIGURATION_TEMPLATES, false).build();
     }
 }

server/src/test/java/org/opensearch/common/settings/SettingsModuleTests.java

@@ -42,9 +42,9 @@
 import java.util.Arrays;
 
 import static java.util.Collections.emptySet;
+import static org.opensearch.common.util.FeatureFlags.EXTENSIONS;
 import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.is;
-import static org.opensearch.common.util.FeatureFlags.EXTENSIONS;
 
 public class SettingsModuleTests extends ModuleTestCase {
 

server/src/test/java/org/opensearch/index/engine/ReadOnlyEngineTests.java

@@ -61,10 +61,10 @@
 import java.util.function.Function;
 
 import static org.opensearch.common.lucene.index.OpenSearchDirectoryReader.getOpenSearchDirectoryReader;
+import static org.opensearch.common.util.FeatureFlags.SEARCHABLE_SNAPSHOT_EXTENDED_COMPATIBILITY;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.greaterThan;
 import static org.hamcrest.Matchers.instanceOf;
-import static org.opensearch.common.util.FeatureFlags.SEARCHABLE_SNAPSHOT_EXTENDED_COMPATIBILITY;
 
 public class ReadOnlyEngineTests extends EngineTestCase {
 

server/src/test/java/org/opensearch/search/aggregations/startree/DateHistogramAggregatorTests.java

@@ -28,7 +28,6 @@
 import org.apache.lucene.tests.index.RandomIndexWriter;
 import org.opensearch.common.Rounding;
 import org.opensearch.common.lucene.Lucene;
-import org.opensearch.common.settings.Settings;
 import org.opensearch.common.util.FeatureFlags;
 import org.opensearch.core.xcontent.XContentBuilder;
 import org.opensearch.index.codec.composite.CompositeIndexFieldInfo;

server/src/test/java/org/opensearch/search/aggregations/startree/KeywordTermsAggregatorTests.java

@@ -31,7 +31,6 @@
 import org.apache.lucene.util.BytesRef;
 import org.apache.lucene.util.NumericUtils;
 import org.opensearch.common.lucene.Lucene;
-import org.opensearch.common.settings.Settings;
 import org.opensearch.common.util.FeatureFlags;
 import org.opensearch.index.codec.composite.CompositeIndexFieldInfo;
 import org.opensearch.index.codec.composite.CompositeIndexReader;

server/src/test/java/org/opensearch/search/aggregations/startree/NumericTermsAggregatorTests.java

@@ -27,7 +27,6 @@
 import org.apache.lucene.tests.index.RandomIndexWriter;
 import org.apache.lucene.util.NumericUtils;
 import org.opensearch.common.lucene.Lucene;
-import org.opensearch.common.settings.Settings;
 import org.opensearch.common.util.FeatureFlags;
 import org.opensearch.core.xcontent.XContentBuilder;
 import org.opensearch.index.codec.composite.CompositeIndexFieldInfo;

server/src/test/java/org/opensearch/search/aggregations/startree/StarTreeFilterTests.java

@@ -24,7 +24,6 @@
 import org.apache.lucene.tests.index.RandomIndexWriter;
 import org.apache.lucene.util.FixedBitSet;
 import org.opensearch.common.lucene.Lucene;
-import org.opensearch.common.settings.Settings;
 import org.opensearch.common.util.FeatureFlags;
 import org.opensearch.core.xcontent.XContentBuilder;
 import org.opensearch.index.codec.composite.CompositeIndexFieldInfo;