Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Unset discoveryNodes object from BaseNodeRequest sent over Transport #17008

Open
SwethaGuptha opened this issue Jan 13, 2025 · 0 comments · May be fixed by #17682
Open

[Feature Request] Unset discoveryNodes object from BaseNodeRequest sent over Transport #17008

SwethaGuptha opened this issue Jan 13, 2025 · 0 comments · May be fixed by #17682
Labels
>breaking Identifies a breaking change. Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0

Comments

@SwethaGuptha
Copy link
Contributor

SwethaGuptha commented Jan 13, 2025

Is your feature request related to a problem? Please describe

As highlighted in #14749, passing the discovery nodes over transport between nodes for any TransportNodesAction is a costly operation. As part of #15131, initialization of discovery nodes object was made conditional based on the extending action. With this change in opensearch project, discovery nodes information is now not sent over transport for all actions extending TransportNodesAction nodes except for TransportNodesReloadSecureSettingsAction.

With the new major version release we can introduce a breaking change to unset the discovery nodes object in BaseNodesRequest when sending request over transport to individual nodes and any action requiring this information should handle this as part of it's own action request instead of relying on the base request.

Describe the solution you'd like

Unset the discovery nodes from BaseNodesRequest when sending request over transport to individual nodes.

Related component

Cluster Manager

Describe alternatives you've considered

No response

Additional context

No response

@SwethaGuptha SwethaGuptha added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 13, 2025
@shwetathareja shwetathareja added >breaking Identifies a breaking change. v3.0.0 Issues and PRs related to version 3.0.0 labels Jan 13, 2025
@SwethaGuptha SwethaGuptha changed the title [Feature Request] Remove discoveryNodes object form BaseNodeRequest for TransportNodesAction [Feature Request] Unset discoveryNodes object from BaseNodeRequest sent over Transport Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. Cluster Manager enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants