Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enhancement - Check if OS pluggins can use RandomAccessInput.readBytes bulk method #17574

Open
asimmahmood1 opened this issue Mar 11, 2025 · 0 comments
Labels
bug Something isn't working Plugins untriaged

Comments

@asimmahmood1
Copy link
Contributor

asimmahmood1 commented Mar 11, 2025

Describe the bug

This is a follow-up to Lucene change apache/lucene#12599, and OS Meta: #16934

Purpose of this issue to each of OS plugins that currently loop using RandomAccessInput.readByte, to instead use RandomAccessInput.readBytes bulk option.

For CoreSearch there was 1 instance found: #17555

Related component

Plugins

To Reproduce

  1. Go through plugin code
  2. Using IDE Find Usages for https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/store/RandomAccessInput.java readByte() method
  3. Check if it can be replaced with RandomAccessInput.readBytes() method.

Expected behavior

Raise PRs and call out any possible benchmark improvements.

Additional Details

Plugins
Go though all Plugins that use https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/store/RandomAccessInput.java

Screenshots
n/a

Host/Environment (please complete the following information):

  • OS: n/a
  • Version 3.0.0

Additional context
Add any other context about the problem here.

@asimmahmood1 asimmahmood1 added bug Something isn't working untriaged labels Mar 11, 2025
@asimmahmood1 asimmahmood1 changed the title [BUG] Enhancement - Update to use RandomAccessInput.readBytes bulk method [BUG] Enhancement - Check if OS pluggins can use RandomAccessInput.readBytes bulk method Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Plugins untriaged
Projects
None yet
Development

No branches or pull requests

1 participant