Fix MissingValues for Lucene 10 #17647
Open
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfroh
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
With the Lucene 10 upgrade, we should not rely on doc values returning NO_MORE_DOCS once they've run out of ords. Instead, we should return a correct value for docValueCount(). Signed-off-by: Michael Froh <[email protected]>
msfroh
force-pushed
the
missing_values_ords
branch
from
5151667 to
71f1b16
Compare
expani
reviewed
Mar 21, 2025
| @@ -359,7 +360,8 @@ public long getValueCount() { | |||
|
|
|||
| @Override | |||
| public int docValueCount() { | |||
| return Math.max(1, values.docValueCount()); | |||
| // If we don't have ordinals, then we just have the missing value | |||
| return hasOrds ? values.docValueCount() : 1; | |||
| } | |||
There was a problem hiding this comment.
The nextOrd() just below this is also not checking for docValueCount.
There was a problem hiding this comment.
That's okay. If the caller calls nextOrd() too many times, the behavior is undefined.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17647 +/- ##
============================================
- Coverage 72.53% 72.42% -0.11%
+ Complexity 65826 65756 -70
============================================
Files 5311 5311
Lines 305073 305073
Branches 44243 44245 +2
============================================
- Hits 221293 220964 -329
- Misses 65688 65995 +307
- Partials 18092 18114 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the Lucene 10 upgrade, we should not rely on doc values returning NO_MORE_DOCS once they've run out of ords. Instead, we should return a correct value for docValueCount().
Related Issues
Resolves #17628
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.