-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ZSTD lib to version 1.5.6-1. #17674
Conversation
Signed-off-by: Mulugeta Mammo <[email protected]>
❌ Gradle check result for a825f9f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@mulugetam there are few PR checks failing that might need a fix. |
Signed-off-by: Mulugeta Mammo <[email protected]>
❌ Gradle check result for e38dc9a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ae4068e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mulugetam <[email protected]>
❌ Gradle check result for b71646f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@reta One of the failures looks like a timeout, but I'm not sure what's going on with the other one. |
@mulugetam indeed, this is a new flaky tests https://build.ci.opensearch.org/job/gradle-check/54945/testReport/org.opensearch.plugin.kinesis/IngestFromKinesisIT/testKinesisIngestion_RewindByOffset/ :((( |
@reta @sarthakaggarwal97 When should we expect this to get merged? |
@mulugetam sure, could you please rebase and fix conflicts? thank you |
Signed-off-by: mulugetam <[email protected]>
❌ Gradle check result for 6530bc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6530bc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6530bc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@reta looks like gradle checks didn't run properly, maybe you can retry the failed tasks. |
@sarthakaggarwal97 did it ~4 times already ... :( |
❌ Gradle check result for 6530bc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6530bc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6530bc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17674 +/- ##
============================================
- Coverage 72.41% 72.29% -0.13%
+ Complexity 65880 65754 -126
============================================
Files 5326 5326
Lines 305548 305548
Branches 44322 44322
============================================
- Hits 221258 220882 -376
- Misses 66101 66533 +432
+ Partials 18189 18133 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17674-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e0a67fd9ca949b14b90dc206231d90158bc35b38
# Push it to GitHub
git push --set-upstream origin backport/backport-17674-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@reta @sarthakaggarwal97 thank you! |
Description
Bumped up the ZSTD library to version 1.5.6-1. This version adds support for custom sequence producers, which makes it possible to add Intel® QAT-accelerated ZSTD in custom-codecs—on top of the existing
qat_deflate
andqat_lz4
. A similar PR is made for custom-codecs.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.