[BUG] Optimisation is not done when profile option is enabled

[expani]

Describe the bug

While analyzing the performance differences in keyword-terms operation in Big5 workload i noticed that the optimization of intersecting between the .tim Term Index unique terms and the Global ordinals doesn't kick in when profile: true is set on a search request.

The optimization returns because the weight is null here

Related component

Search

To Reproduce

Run Big5 benchmark on a local setup ( single node....doesn't matter )

Run the keyword-terms query with and without profile and debug to check if the optimization of GlobalOrdinalsStringTermsAggregator#tryCollectFromTermFrequencies gets skipped when profile is enabled.

Expected behavior

We should be using the optimization even when the query is being profiled.

Additional Details

No response

[kkewwei]

I think it reasonable. As long as it does not involve cache-related pruning, we can execute the profile as usual.

It appears that by overriding the setWeight in both InternalProfileCollector and ProfilingAggregator, we can effectively achieve the desired outcome.