Skip to content

IndexingMemoryController Integration for VSRs and ArrowWriters for parquet-data-format module #19941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 12, 2025
Merged

IndexingMemoryController Integration for VSRs and ArrowWriters for parquet-data-format module #19941

merged 3 commits into from
Nov 12, 2025
+361 −232

Conversation

@raghuvanshraj
Copy link
Contributor

@raghuvanshraj raghuvanshraj commented Nov 10, 2025 •
edited
Loading

IndexingMemoryController Integration for VSRs and ArrowWriters for parquet-data-format module

  • Integrated native memory tracking for VSRs and ArrowWriters in IndexingMemoryController
  • Fixed ArrowBufferPool allocator creation logic to have a single RootAllocator per shard and ChildAllocators for each ParquetWriter
  • Fixed VSR rotation bugs in ParquetDocumentInput.addToWriter code path

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

|                                                         Metric |         Task |       Value |   Unit |
|---------------------------------------------------------------:|-------------:|------------:|-------:|
|                     Cumulative indexing time of primary shards |              |           0 |    min |
|             Min cumulative indexing time across primary shards |              |           0 |    min |
|          Median cumulative indexing time across primary shards |              |           0 |    min |
|             Max cumulative indexing time across primary shards |              |           0 |    min |
|            Cumulative indexing throttle time of primary shards |              |     10.8082 |    min |
|    Min cumulative indexing throttle time across primary shards |              |     10.8082 |    min |
| Median cumulative indexing throttle time across primary shards |              |     10.8082 |    min |
|    Max cumulative indexing throttle time across primary shards |              |     10.8082 |    min |
|                        Cumulative merge time of primary shards |              |           0 |    min |
|                       Cumulative merge count of primary shards |              |           0 |        |
|                Min cumulative merge time across primary shards |              |           0 |    min |
|             Median cumulative merge time across primary shards |              |           0 |    min |
|                Max cumulative merge time across primary shards |              |           0 |    min |
|               Cumulative merge throttle time of primary shards |              |           0 |    min |
|       Min cumulative merge throttle time across primary shards |              |           0 |    min |
|    Median cumulative merge throttle time across primary shards |              |           0 |    min |
|       Max cumulative merge throttle time across primary shards |              |           0 |    min |
|                      Cumulative refresh time of primary shards |              |           0 |    min |
|                     Cumulative refresh count of primary shards |              |           2 |        |
|              Min cumulative refresh time across primary shards |              |           0 |    min |
|           Median cumulative refresh time across primary shards |              |           0 |    min |
|              Max cumulative refresh time across primary shards |              |           0 |    min |
|                        Cumulative flush time of primary shards |              |     0.34075 |    min |
|                       Cumulative flush count of primary shards |              |        2205 |        |
|                Min cumulative flush time across primary shards |              |     0.34075 |    min |
|             Median cumulative flush time across primary shards |              |     0.34075 |    min |
|                Max cumulative flush time across primary shards |              |     0.34075 |    min |
|                                        Total Young Gen GC time |              |       3.534 |      s |
|                                       Total Young Gen GC count |              |         175 |        |
|                                          Total Old Gen GC time |              |           0 |      s |
|                                         Total Old Gen GC count |              |           0 |        |
|                                                     Store size |              | 1.93715e-07 |     GB |
|                                                  Translog size |              | 5.12227e-08 |     GB |
|                                         Heap used for segments |              |           0 |     MB |
|                                       Heap used for doc values |              |           0 |     MB |
|                                            Heap used for terms |              |           0 |     MB |
|                                            Heap used for norms |              |           0 |     MB |
|                                           Heap used for points |              |           0 |     MB |
|                                    Heap used for stored fields |              |           0 |     MB |
|                                                  Segment count |              |           0 |        |
|                                                 Min Throughput | index-append |     42552.7 | docs/s |
|                                                Mean Throughput | index-append |     43295.4 | docs/s |
|                                              Median Throughput | index-append |     42993.1 | docs/s |
|                                                 Max Throughput | index-append |     46663.1 | docs/s |
|                                        50th percentile latency | index-append |     784.922 |     ms |
|                                        90th percentile latency | index-append |        1093 |     ms |
|                                        99th percentile latency | index-append |     1433.91 |     ms |
|                                      99.9th percentile latency | index-append |     1753.09 |     ms |
|                                     99.99th percentile latency | index-append |     2087.86 |     ms |
|                                       100th percentile latency | index-append |     2279.25 |     ms |
|                                   50th percentile service time | index-append |     784.922 |     ms |
|                                   90th percentile service time | index-append |        1093 |     ms |
|                                   99th percentile service time | index-append |     1433.91 |     ms |
|                                 99.9th percentile service time | index-append |     1753.09 |     ms |
|                                99.99th percentile service time | index-append |     2087.86 |     ms |
|                                  100th percentile service time | index-append |     2279.25 |     ms |
|                                                     error rate | index-append |           0 |      % |

------------------------------------
[INFO] ✅ SUCCESS (took 2362 seconds)
------------------------------------
Screenshot 2025-11-10 at 1 19 44 PM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

❌ Gradle check result for 8990894: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

❌ Gradle check result for 801e698: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@raghuvanshraj
IndexingMemoryController Integration for VSRs and ArrowWriters for pa…
e389179 
…rquet-data-format module

- Integrated native memory tracking for VSRs and ArrowWriters in IndexingMemoryController
- Fixed ArrowBufferPool allocator creation logic to have a single RootAllocator per shard and ChildAllocators for each ParquetWriter
- Fixed VSR rotation bugs in ParquetDocumentInput.addToWriter code path

Signed-off-by: Raghuvansh Raj <[email protected]>
@raghuvanshraj
Hardcoding max root allocation bytes and max child allocator bytes in…
8792c8b 
… ArrowBufferPool
@raghuvanshraj raghuvanshraj force-pushed the feature/datafusion-imc-pr branch from 801e698 to 8792c8b Compare November 12, 2025 09:18
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

❌ Gradle check result for 839ffd0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

mgodwan
mgodwan reviewed Nov 12, 2025
View reviewed changes
...parquet-data-format/src/main/java/com/parquet/parquetdataformat/ParquetDataFormatPlugin.java

public static final Setting<String> INDEX_MAX_NATIVE_ALLOCATION = Setting.simpleString(
"index.parquet.max_native_allocation",
DEFAULT_MAX_NATIVE_ALLOCATION,
Copy link
Member

@mgodwan mgodwan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Validation for syntax of setting value.

mgodwan
mgodwan reviewed Nov 12, 2025
View reviewed changes
modules/parquet-data-format/src/main/java/com/parquet/parquetdataformat/vsr/VSRManager.java
private final VSRPool vsrPool;

public VSRManager(String fileName, Schema schema) {
public VSRManager(String fileName, Schema schema, ArrowBufferPool arrowBufferPool) {
Copy link
Member

@mgodwan mgodwan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be able to consume VSRPool?

@bharath-techie bharath-techie merged commit 459ead6 into opensearch-project:feature/datafusion Nov 12, 2025
5 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

1 more reviewer

@mgodwan mgodwan mgodwan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raghuvanshraj @mgodwan @bharath-techie