-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update a misleading comment in the _doc get path #19947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a misleading comment in the _doc get path #19947
Conversation
Signed-off-by: Finn Carroll <[email protected]>
|
❌ Gradle check result for 77607e3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 77607e3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 77607e3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <[email protected]>
|
❌ Gradle check result for 1f565cc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 1f565cc: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19947 +/- ##
============================================
+ Coverage 73.25% 73.30% +0.04%
- Complexity 71555 71612 +57
============================================
Files 5785 5785
Lines 326828 326828
Branches 47295 47295
============================================
+ Hits 239429 239587 +158
+ Misses 68163 67968 -195
- Partials 19236 19273 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Updating an out of date comment which was particularly confusing to me.
Both portions of this comment seem to be deprecated and are a bit misleading. API _GET calls can take this code path and read directly from translog. This is the default it seems as
readFromTranslogis always true andGetRequestdefaults realtime to true.The second line is not clear to me at all. It seems update calls would be entirely concerned with consistency. In the case where we can't reach from translog we attempt
refreshIfNeededbefore fetching the document from the index.Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.