address comments

Signed-off-by: Kaituo Li <[email protected]>

Author: kaituo

public/components/RefreshForecastersButton/__tests__/RefreshForecastersButton.test.tsx

@@ -14,6 +14,13 @@ import { render } from '@testing-library/react';
 import { Router } from 'react-router-dom';
 import { createMemoryHistory } from 'history';
 import { RefreshForecastersButton } from '../RefreshForecastersButton';
+import { getDataSourceEnabled, } from '../../../services';
+
+// Mock the module
+jest.mock('../../../services', () => ({
+  ...jest.requireActual('../../../services'),
+  getDataSourceEnabled: jest.fn(),
+}));
 
 describe('<RefreshForecastersButton /> spec', () => {
   beforeAll(() => {
@@ -28,6 +35,13 @@ describe('<RefreshForecastersButton /> spec', () => {
     });
   });
 
+  beforeEach(() => {
+    // Mock the return value
+    (getDataSourceEnabled as jest.Mock).mockReturnValue({
+      enabled: false, // or true, depending on what you want to test
+    });
+  });
+
   test('renders component', () => {
     const history = createMemoryHistory();
     const { container, getByText } = render(

public/components/RefreshForecastersButton/__tests__/__snapshots__/RefreshForecastersButton.test.tsx.snap

@@ -0,0 +1,43 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`<RefreshForecastersButton /> spec renders component 1`] = `
+<div
+  class="euiFlexGroup euiFlexGroup--gutterMedium euiFlexGroup--justifyContentCenter euiFlexGroup--directionRow euiFlexGroup--responsive"
+>
+  <div
+    class="euiFlexItem euiFlexItem--flexGrowZero"
+  >
+    <a
+      class="euiButton euiButton--primary euiButton--small"
+      data-test-subj="refreshForecastersButton"
+      href="forecasting#/forecasters?"
+      rel="noreferrer"
+      style="width: 200px;"
+    >
+      <span
+        class="euiButtonContent euiButton__content"
+      >
+        <svg
+          aria-hidden="true"
+          class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
+          focusable="false"
+          height="16"
+          role="img"
+          viewBox="0 0 16 16"
+          width="16"
+          xmlns="http://www.w3.org/2000/svg"
+        >
+          <path
+            d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
+          />
+        </svg>
+        <span
+          class="euiButton__text"
+        >
+          Refresh
+        </span>
+      </span>
+    </a>
+  </div>
+</div>
+`;

public/pages/ConfigureForecastModel/components/AdvancedSettings/AdvancedSettings.tsx

@@ -1,3 +1,14 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Modifications Copyright OpenSearch Contributors. See
+ * GitHub history for details.
+ */
+
 import { useEffect, useState } from 'react';
 import {
   EuiFlexItem,
@@ -30,7 +41,8 @@ import {
 import { FormattedFormRow } from '../../../../components/FormattedFormRow/FormattedFormRow';
 import { SparseDataOptionValue } from '../../utils/constants';
 import '../../index.scss';
-import React from 'react';
+import React, { ReactElement } from 'react';
+import { toNumberOrEmpty } from '../../utils/helpers';
 
 interface AdvancedSettingsProps {
   isEditable?: boolean;
@@ -111,8 +123,7 @@ export function AdvancedSettings({ isEditable = true }: AdvancedSettingsProps) {
                         value={field.value || ''}
                         disabled={!isEditable}
                         onChange={(e) => {
-                          const raw = e.target.value;
-                          form.setFieldValue(field.name, raw === '' ? '' : Number(raw));
+                          form.setFieldValue(field.name, toNumberOrEmpty(e.target.value));
                         }}
                       />
                     </div>
@@ -158,8 +169,7 @@ export function AdvancedSettings({ isEditable = true }: AdvancedSettingsProps) {
                         value={field.value || ''}
                         disabled={!isEditable}
                         onChange={(e) => {
-                          const raw = e.target.value;
-                          form.setFieldValue(field.name, raw === '' ? '' : Number(raw));
+                          form.setFieldValue(field.name, toNumberOrEmpty(e.target.value));
                         }}
                       />
                     </div>
@@ -225,8 +235,7 @@ export function AdvancedSettings({ isEditable = true }: AdvancedSettingsProps) {
                         value={field.value || ''}
                         disabled={!isEditable}
                         onChange={(e) => {
-                          const raw = e.target.value;
-                          form.setFieldValue(field.name, raw === '' ? '' : Number(raw));
+                          form.setFieldValue(field.name, toNumberOrEmpty(e.target.value));
                         }}
                       />
                     </div>
@@ -309,8 +318,7 @@ export function AdvancedSettings({ isEditable = true }: AdvancedSettingsProps) {
                                             name={field.name}
                                             disabled={!isEditable}
                                             onChange={(e) => {
-                                              const raw = e.target.value;
-                                              form.setFieldValue(field.name, raw === '' ? '' : Number(raw));
+                                              form.setFieldValue(field.name, toNumberOrEmpty(e.target.value));
                                             }}
                                             value={field.value || ''}
                                           />