remove redundant error toast (#515)

* remove redundant error toast

Signed-off-by: Yulong Ruan <[email protected]>

* tweaks button text

Signed-off-by: Yulong Ruan <[email protected]>

* update CHANGELOG

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>

Author: ruanyl

CHANGELOG.md

@@ -8,8 +8,10 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ### Enhancements
 
+- remove redundant error toast([#515](https://github.com/opensearch-project/dashboards-assistant/pull/515))
 - Add auto suggested aggregation for text2Viz ([#514](https://github.com/opensearch-project/dashboards-assistant/pull/514))
 
+
 ### Bug Fixes
 
 ### Infrastructure

public/components/incontext_insight/generate_popover_body.test.tsx

@@ -144,10 +144,10 @@ describe('GeneratePopoverBody', () => {
     );
 
     // insight button is visible
-    const insightButton = screen.getAllByText('View insight')[0];
+    const insightButton = screen.getAllByText('View insights')[0];
     expect(insightButton).toBeInTheDocument();
 
-    // 2. Click insight button to view insight
+    // 2. Click insight button to view insights
     fireEvent.click(insightButton);
     // title is back button + 'Insight With RAG'
     let backButton = getByLabelText('back-to-summary');
@@ -224,7 +224,7 @@ describe('GeneratePopoverBody', () => {
     );
 
     // insight button is not visible
-    expect(screen.queryAllByLabelText('View insight')).toHaveLength(0);
+    expect(screen.queryAllByLabelText('View insights')).toHaveLength(0);
     // Only call http post 1 time.
     expect(mockPost).toHaveBeenCalledTimes(1);
   });
@@ -286,7 +286,7 @@ describe('GeneratePopoverBody', () => {
     // Show summary content although insight generation failed
     expect(getByText('Generated summary content')).toBeInTheDocument();
     // insight button is not visible for this alert
-    expect(screen.queryAllByLabelText('View insight')).toHaveLength(0);
+    expect(screen.queryAllByLabelText('View insights')).toHaveLength(0);
   });
 
   it('should not display discover link if monitor type is not  query_level_monitor or bucket_level_monitor', async () => {

public/components/incontext_insight/generate_popover_body.tsx

@@ -345,7 +345,7 @@ export const GeneratePopoverBody: React.FC<{
                   defaultMessage: 'Back to summary',
                 })
               : i18n.translate('assistantDashboards.incontextInsight.viewInsight', {
-                  defaultMessage: 'View insight',
+                  defaultMessage: 'View insights',
                 })}
           </TraceButton>
         )}

public/components/visualization/text2viz.tsx

@@ -148,11 +148,6 @@ export const Text2Viz = () => {
         if (result.error) {
           const msg = `Unable to generate a visualization. ${result.error.message}`;
           setErrorMessage(msg);
-          notifications.toasts.addError(new Error(msg), {
-            title: i18n.translate('dashboardAssistant.feature.text2viz.error', {
-              defaultMessage: 'Error while executing text to visualization',
-            }),
-          });
         } else {
           setEditorInput(JSON.stringify(result.vega, undefined, 4));
 
@@ -171,7 +166,7 @@ export const Text2Viz = () => {
     return () => {
       subscription?.unsubscribe();
     };
-  }, [http, notifications, usageCollection]);
+  }, [usageCollection]);
 
   /**
    * Loads the saved object from id when editing an existing visualization