Skip to content

Commit 3da9814

Browse files
authored
added placeholder change for metrics picker (#1906)
* added placeholder change for metrics picker Signed-off-by: sumukhswamy <[email protected]> * updated release notes Signed-off-by: sumukhswamy <[email protected]> * updated tests Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]>
1 parent 9864ef2 commit 3da9814

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap

+3-3
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
184184
},
185185
]
186186
}
187-
placeholder="Select a data source"
187+
placeholder="Select a metric source"
188188
selectedOptions={Array []}
189189
singleSelection={
190190
Object {
@@ -216,7 +216,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
216216
onFocus={[Function]}
217217
onOpenListClick={[Function]}
218218
onRemoveOption={[Function]}
219-
placeholder="Select a data source"
219+
placeholder="Select a metric source"
220220
rootId={[Function]}
221221
searchValue=""
222222
selectedOptions={Array []}
@@ -259,7 +259,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
259259
<p
260260
className="euiComboBoxPlaceholder"
261261
>
262-
Select a data source
262+
Select a metric source
263263
</p>
264264
<AutosizeInput
265265
aria-controls=""

public/components/metrics/sidebar/data_source_picker.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ export const DataSourcePicker = ({
1717
selectedDataSource,
1818
setSelectedDataSource,
1919
}: DataSourcePickerMenuProps) => {
20-
const onChange = (selectedDataSource) => {
21-
setSelectedDataSource(selectedDataSource);
20+
const onChange = (selectedMetricSource) => {
21+
setSelectedDataSource(selectedMetricSource);
2222
};
2323

2424
return (
@@ -27,7 +27,7 @@ export const DataSourcePicker = ({
2727
<h5>Metrics source</h5>
2828
</EuiTitle>
2929
<EuiComboBox
30-
placeholder="Select a data source"
30+
placeholder="Select a metric source"
3131
singleSelection={{ asPlainText: true }}
3232
options={DATASOURCE_OPTIONS}
3333
selectedOptions={selectedDataSource || []}

release-notes/dashboards-observability.release-notes-2.15.0.0.md

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Compatible with OpenSearch and OpenSearch Dashboards version 2.15.0
3636
* [Bug fix] Add conditional rendering for data connection page's tabs ([#1756](https://github.com/opensearch-project/dashboards-observability/pull/1756))
3737
* removed update button from explorer ([#1755](https://github.com/opensearch-project/dashboards-observability/pull/1755))
3838
* (query assist) remove caching agent id ([#1734](https://github.com/opensearch-project/dashboards-observability/pull/1734))
39+
* added placeholder change for metrics picker ([#1906](https://github.com/opensearch-project/dashboards-observability/pull/1906))
3940

4041
### Maintenance
4142
* Remove mocha from dependencies ([#1890](https://github.com/opensearch-project/dashboards-observability/pull/1890))

0 commit comments

Comments
 (0)