1050: Reduce build warnings. (#1051)

github-actions[bot] · siddharthabingi · Siddhartha Bingi · github-actions[bot] · commit 018750da8258 · 2025-02-10T18:54:36.000Z
* Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com> * Adding integration tests for workflow provisioning under multitenancy Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com> * Addressing comments Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com> --------- Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com> Co-authored-by: Siddhartha Bingi <sidbingi@amazon.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * 1050: * Changed the indentation from spaces to tab. * Included private no-args constructors. * refactoring. Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * Update template for alert summary with new log pattern tools (#1021) * Update template for alert summary with log pattern Signed-off-by: Sihan He <hesihan@amazon.com> * Update ChangeLog Signed-off-by: Sihan He <hesihan@amazon.com> --------- Signed-off-by: Sihan He <hesihan@amazon.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> * JDK 11 compatible changes. Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> --------- Signed-off-by: Siddhartha Bingi <sidbingi@amazon.com> Signed-off-by: Vikas Adyar <vikasadyar@gmail.com> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Sihan He <hesihan@amazon.com> Co-authored-by: Siddhartha Bingi <siddharthabingi@gmail.com> Co-authored-by: Siddhartha Bingi <sidbingi@amazon.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: 000FLMS <hesihan@amazon.com> (cherry picked from commit 2acbb56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
diff --git a/formatter/formatting.gradle b/formatter/formatting.gradle
@@ -6,8 +6,7 @@ allprojects {
             target '**/*.java'
 
             removeUnusedImports()
-            importOrder(
-                    'de.thetaphi',
+            importOrder('de.thetaphi',
                     'com.carrotsearch',
                     'com.fasterxml',
                     'com.avast',
@@ -19,11 +18,10 @@ allprojects {
                     'javax',
                     'java',
                     '',
-                    '\\#java|\\#org.opensearch|\\#org.hamcrest|\\#'
-            )
+                    '\\#java|\\#org.opensearch|\\#org.hamcrest|\\#')
             eclipse().configFile rootProject.file('formatter/formatterConfig.xml')
             trimTrailingWhitespace()
-            endWithNewline();
+            endWithNewline()
 
             // See DEVELOPER_GUIDE.md for details of when to enable this.
             if (System.getProperty('spotless.paddedcell') != null) {
@@ -35,10 +33,10 @@ allprojects {
 
             trimTrailingWhitespace()
             endWithNewline()
-            indentWithSpaces()
+            leadingTabsToSpaces()
         }
         format("license", {
-            licenseHeaderFile("${rootProject.file("formatter/license-header.txt")}", "package ");
+            licenseHeaderFile("${rootProject.file("formatter/license-header.txt")}", "package ")
             target("src/*/java/**/*.java")
         })
     }
diff --git a/src/main/java/org/opensearch/flowframework/util/ApiSpecFetcher.java b/src/main/java/org/opensearch/flowframework/util/ApiSpecFetcher.java
@@ -40,6 +40,8 @@ public class ApiSpecFetcher {
         PARSE_OPTIONS.setResolveFully(true);
     }
 
+    private ApiSpecFetcher() {}
+
     /**
      * Parses the OpenAPI specification directly from the URI.
      *
diff --git a/src/main/java/org/opensearch/flowframework/util/EncryptorUtils.java b/src/main/java/org/opensearch/flowframework/util/EncryptorUtils.java
@@ -76,7 +76,7 @@ public class EncryptorUtils {
     private static final String WRAPPING_ALGORITHM = "AES/GCM/NOPADDING";
 
     // concurrent map can't have null as a key. This key is to support single tenancy
-    public static final String DEFAULT_TENANT_ID = "";
+    private static final String DEFAULT_TENANT_ID = "";
 
     private final ClusterService clusterService;
     private final Client client;
diff --git a/src/main/java/org/opensearch/flowframework/util/TenantAwareHelper.java b/src/main/java/org/opensearch/flowframework/util/TenantAwareHelper.java
@@ -23,6 +23,8 @@
  */
 public class TenantAwareHelper {
 
+    private TenantAwareHelper() {}
+
     /**
      * Validates the tenant ID based on the multi-tenancy feature setting.
      *
diff --git a/src/main/java/org/opensearch/flowframework/util/WorkflowTimeoutUtility.java b/src/main/java/org/opensearch/flowframework/util/WorkflowTimeoutUtility.java
@@ -34,6 +34,8 @@ public class WorkflowTimeoutUtility {
 
     private static final Logger logger = LogManager.getLogger(WorkflowTimeoutUtility.class);
 
+    private WorkflowTimeoutUtility() {}
+
     /**
      * Schedules a timeout task for a workflow execution.
      *

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,8 @@ public class ApiSpecFetcher {`
`40`	`40`	`PARSE_OPTIONS.setResolveFully(true);`
`41`	`41`	`}`
`42`	`42`
	`43`	`+ private ApiSpecFetcher() {}`
	`44`	`+`
`43`	`45`	`/**`
`44`	`46`	`* Parses the OpenAPI specification directly from the URI.`
`45`	`47`	`*`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@`
`23`	`23`	`*/`
`24`	`24`	`public class TenantAwareHelper {`
`25`	`25`
	`26`	`+ private TenantAwareHelper() {}`
	`27`	`+`
`26`	`28`	`/**`
`27`	`29`	`* Validates the tenant ID based on the multi-tenancy feature setting.`
`28`	`30`	`*`
Original file line number	Diff line number	Diff line change
`@@ -34,6 +34,8 @@ public class WorkflowTimeoutUtility {`
`34`	`34`
`35`	`35`	`private static final Logger logger = LogManager.getLogger(WorkflowTimeoutUtility.class);`
`36`	`36`
	`37`	`+ private WorkflowTimeoutUtility() {}`
	`38`	`+`
`37`	`39`	`/**`
`38`	`40`	`* Schedules a timeout task for a workflow execution.`
`39`	`41`	`*`