Update RemoteIndexBuildStrategyTests.java (#2597)

owenhalpert · web-flow · commit 46d30b8af14a · 2025-03-12T12:28:50.000-07:00
Fix flaky test

Signed-off-by: owenhalpert &lt;ohalpert@gmail.com&gt;
diff --git a/src/test/java/org/opensearch/knn/index/codec/nativeindex/remote/RemoteIndexBuildStrategyTests.java b/src/test/java/org/opensearch/knn/index/codec/nativeindex/remote/RemoteIndexBuildStrategyTests.java
@@ -77,6 +77,6 @@ public void testShouldBuildIndexRemotely() {
         when(clusterSettings.get(KNN_REMOTE_VECTOR_REPO_SETTING)).thenReturn("test-vector-repo");
         when(clusterService.getClusterSettings()).thenReturn(clusterSettings);
         KNNSettings.state().setClusterService(clusterService);
-        assertTrue(RemoteIndexBuildStrategy.shouldBuildIndexRemotely(indexSettings, randomIntBetween(BYTE_SIZE - 1, BYTE_SIZE * 2)));
+        assertTrue(RemoteIndexBuildStrategy.shouldBuildIndexRemotely(indexSettings, randomIntBetween(BYTE_SIZE, BYTE_SIZE * 2)));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,6 @@ public void testShouldBuildIndexRemotely() {`
`77`	`77`	`when(clusterSettings.get(KNN_REMOTE_VECTOR_REPO_SETTING)).thenReturn("test-vector-repo");`
`78`	`78`	`when(clusterService.getClusterSettings()).thenReturn(clusterSettings);`
`79`	`79`	`KNNSettings.state().setClusterService(clusterService);`
`80`		`- assertTrue(RemoteIndexBuildStrategy.shouldBuildIndexRemotely(indexSettings, randomIntBetween(BYTE_SIZE - 1, BYTE_SIZE * 2)));`
	`80`	`+ assertTrue(RemoteIndexBuildStrategy.shouldBuildIndexRemotely(indexSettings, randomIntBetween(BYTE_SIZE, BYTE_SIZE * 2)));`
`81`	`81`	`}`
`82`	`82`	`}`