You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All notable changes to this project are documented in this file.
3
+
4
+
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). See the [CONTRIBUTING guide](./CONTRIBUTING.md#Changelog) for instructions on how to add changelog entries.
Copy file name to clipboardexpand all lines: CONTRIBUTING.md
+37
Original file line number
Diff line number
Diff line change
@@ -8,6 +8,7 @@ OpenSearch k-NN is a community project that is built and maintained by people ju
8
8
-[Ways to Contribute](#ways-to-contribute)
9
9
-[Developer Certificate of Origin](#developer-certificate-of-origin)
10
10
-[License Headers](#license-headers)
11
+
-[Changelog](#changelog)
11
12
-[Review Process](#review-process)
12
13
13
14
@@ -129,6 +130,42 @@ New files in your code contributions should contain the following license header
129
130
# SPDX-License-Identifier: Apache-2.0
130
131
```
131
132
133
+
## Changelog
134
+
135
+
OpenSearch maintains version specific changelog by enforcing a change to the ongoing [CHANGELOG](CHANGELOG.md) file adhering to the [Keep A Changelog](https://keepachangelog.com/en/1.0.0/) format. The purpose of the changelog is for the contributors and maintainers to incrementally build the release notes throughout the development process to avoid a painful and error-prone process of attempting to compile the release notes at release time. On each release the "unreleased" entries of the changelog are moved to the appropriate release notes document in the `./release-notes` folder. Also, incrementally building the changelog provides a concise, human-readable list of significant features that have been added to the unreleased version under development.
136
+
137
+
### Which changes require a CHANGELOG entry?
138
+
Changelogs are intended for operators/administrators, developers integrating with libraries and APIs, and end-users interacting with OpenSearch Dashboards and/or the REST API (collectively referred to as "user"). In short, any change that a user of OpenSearch might want to be aware of should be included in the changelog. The changelog is _not_ intended to replace the git commit log that developers of OpenSearch itself rely upon. The following are some examples of changes that should be in the changelog:
139
+
140
+
- A newly added feature
141
+
- A fix for a user-facing bug
142
+
- Dependency updates
143
+
- Fixes for security issues
144
+
145
+
The following are some examples where a changelog entry is not necessary:
146
+
147
+
- Adding, modifying, or fixing tests
148
+
- An incremental PR for a larger feature (such features should include _one_ changelog entry for the feature)
149
+
- Documentation changes or code refactoring
150
+
- Build-related changes
151
+
152
+
Any PR that does not include a changelog entry will result in a failure of the validation workflow in GitHub. If the contributor and maintainers agree that no changelog entry is required, then the `skip-changelog` label can be applied to the PR which will result in the workflow passing.
153
+
154
+
### How to add my changes to [CHANGELOG](CHANGELOG.md)?
155
+
156
+
Adding in the change is two step process:
157
+
1. Add your changes to the corresponding section within the CHANGELOG file with dummy pull request information, publish the PR
158
+
2. Update the entry for your change in [`CHANGELOG.md`](CHANGELOG.md) and make sure that you reference the pull request there.
159
+
160
+
### Where should I put my CHANGELOG entry?
161
+
Please review the [branching strategy](https://github.com/opensearch-project/.github/blob/main/RELEASING.md#opensearch-branching) document. The changelog on the `main` branch will contain sections for the _next major_ and _next minor_ releases. Your entry should go into the section it is intended to be released in. In practice, most changes to `main` will be backported to the next minor release so most entries will likely be in that section.
162
+
163
+
The following examples assume the _next major_ release on main is 3.0, then _next minor_ release is 2.5, and the _current_ release is 2.4.
164
+
165
+
-**Add a new feature to release in next minor:** Add a changelog entry to `[Unreleased 2.x]` on main, then backport to 2.x (including the changelog entry).
166
+
-**Introduce a breaking API change to release in next major:** Add a changelog entry to `[Unreleased 3.0]` on main, do not backport.
167
+
-**Upgrade a dependency to fix a CVE:** Add a changelog entry to `[Unreleased 2.x]` on main, then backport to 2.x (including the changelog entry), then backport to 2.4 and ensure the changelog entry is added to `[Unreleased 2.4.1]`.
168
+
132
169
## Review Process
133
170
134
171
We deeply appreciate everyone who takes the time to make a contribution. We will review all contributions as quickly as possible. As a reminder, [opening an issue](https://github.com/opensearch-project/k-NN/issues/new/choose) discussing your change before you make it is the best way to smooth the PR process. This will prevent a rejection because someone else is already working on the problem, or because the solution is incompatible with the architectural direction.
0 commit comments