Skip to content

Commit 7748952

Browse files
committed
apply spotless
Signed-off-by: Jiaping Zeng <[email protected]>
1 parent 144e86f commit 7748952

File tree

6 files changed

+21
-15
lines changed

6 files changed

+21
-15
lines changed

ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/agent/AgentUtils.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,10 @@ public class AgentUtils {
148148
public static Map<String, String> extractRequestHeaders(Client client) {
149149
try {
150150
@SuppressWarnings("unchecked")
151-
Map<String, String> headers = client.threadPool().getThreadContext().getTransient(
152-
CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY
153-
);
151+
Map<String, String> headers = client
152+
.threadPool()
153+
.getThreadContext()
154+
.getTransient(CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
154155
return headers != null ? headers : Collections.emptyMap();
155156
} catch (Exception e) {
156157
log.warn("Failed to retrieve MCP request headers from ThreadContext", e);

ml-algorithms/src/test/java/org/opensearch/ml/engine/algorithms/agent/AgentUtilsTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2007,11 +2007,11 @@ public void testExtractRequestHeaders_WithValidHeaders() {
20072007
Map<String, String> expectedHeaders = new HashMap<>();
20082008
expectedHeaders.put("x-amzn-fas-accesskey", "access-key-value");
20092009
expectedHeaders.put("x-amzn-datasources", "https://example.aos.us-east-1.on.aws");
2010-
2010+
20112011
ThreadContext realThreadContext = new ThreadContext(Settings.EMPTY);
20122012
when(client.threadPool()).thenReturn(threadPool);
20132013
when(threadPool.getThreadContext()).thenReturn(realThreadContext);
2014-
2014+
20152015
realThreadContext.putTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY, expectedHeaders);
20162016

20172017
Map<String, String> result = AgentUtils.extractRequestHeaders(client);
@@ -2036,11 +2036,11 @@ public void testExtractRequestHeaders_WithNoHeaders() {
20362036
@Test
20372037
public void testExtractRequestHeaders_WithEmptyHeaders() {
20382038
Map<String, String> emptyHeaders = new HashMap<>();
2039-
2039+
20402040
ThreadContext realThreadContext = new ThreadContext(Settings.EMPTY);
20412041
when(client.threadPool()).thenReturn(threadPool);
20422042
when(threadPool.getThreadContext()).thenReturn(realThreadContext);
2043-
2043+
20442044
realThreadContext.putTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY, emptyHeaders);
20452045

20462046
Map<String, String> result = AgentUtils.extractRequestHeaders(client);
@@ -2065,11 +2065,11 @@ public void testExtractRequestHeaders_WithException() {
20652065
public void testExtractRequestHeaders_WithPartialHeaders() {
20662066
Map<String, String> partialHeaders = new HashMap<>();
20672067
partialHeaders.put("x-amzn-fas-accesskey", "access-key-value");
2068-
2068+
20692069
ThreadContext realThreadContext = new ThreadContext(Settings.EMPTY);
20702070
when(client.threadPool()).thenReturn(threadPool);
20712071
when(threadPool.getThreadContext()).thenReturn(realThreadContext);
2072-
2072+
20732073
realThreadContext.putTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY, partialHeaders);
20742074

20752075
Map<String, String> result = AgentUtils.extractRequestHeaders(client);

plugin/src/main/java/org/opensearch/ml/rest/RestMLExecuteAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
import static org.opensearch.ml.utils.RestActionUtils.PARAMETER_AGENT_ID;
1515
import static org.opensearch.ml.utils.RestActionUtils.PARAMETER_ALGORITHM;
1616
import static org.opensearch.ml.utils.RestActionUtils.PARAMETER_TOOL_NAME;
17-
import static org.opensearch.ml.utils.RestActionUtils.storeMcpRequestHeaders;
1817
import static org.opensearch.ml.utils.RestActionUtils.getAlgorithm;
1918
import static org.opensearch.ml.utils.RestActionUtils.isAsync;
19+
import static org.opensearch.ml.utils.RestActionUtils.storeMcpRequestHeaders;
2020
import static org.opensearch.ml.utils.TenantAwareHelper.getTenantID;
2121

2222
import java.io.IOException;

plugin/src/main/java/org/opensearch/ml/rest/RestMLExecuteStreamAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import static org.opensearch.ml.utils.MLExceptionUtils.AGENT_FRAMEWORK_DISABLED_ERR_MSG;
1515
import static org.opensearch.ml.utils.MLExceptionUtils.STREAM_DISABLED_ERR_MSG;
1616
import static org.opensearch.ml.utils.RestActionUtils.PARAMETER_AGENT_ID;
17-
import static org.opensearch.ml.utils.RestActionUtils.storeMcpRequestHeaders;
1817
import static org.opensearch.ml.utils.RestActionUtils.isAsync;
18+
import static org.opensearch.ml.utils.RestActionUtils.storeMcpRequestHeaders;
1919
import static org.opensearch.ml.utils.TenantAwareHelper.getTenantID;
2020

2121
import java.io.ByteArrayOutputStream;

plugin/src/main/java/org/opensearch/ml/utils/RestActionUtils.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,10 @@ public static void storeMcpRequestHeaders(RestRequest request, Client client) {
377377

378378
public static Map<String, String> getMcpRequestHeaders(Client client) {
379379
try {
380-
Map<String, String> headers = client.threadPool().getThreadContext().getTransient(CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
380+
Map<String, String> headers = client
381+
.threadPool()
382+
.getThreadContext()
383+
.getTransient(CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
381384
return headers != null ? headers : Collections.emptyMap();
382385
} catch (Exception e) {
383386
log.warn("Failed to retrieve MCP request headers from ThreadContext", e);

plugin/src/test/java/org/opensearch/ml/utils/RestActionUtilsTests.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ public void testStoreMcpRequestHeaders_withAllHeaders() {
404404
headers.put("x-amzn-fas-secretkey", List.of("secret-key-value"));
405405
headers.put("x-amzn-fas-sessiontoken", List.of("session-token-value"));
406406
headers.put("x-amzn-datasources", List.of("https://example.aos.us-east-1.on.aws"));
407-
407+
408408
FakeRestRequest request = new FakeRestRequest.Builder(xContentRegistry())
409409
.withMethod(RestRequest.Method.POST)
410410
.withPath(urlPath)
@@ -422,7 +422,8 @@ public void testStoreMcpRequestHeaders_withAllHeaders() {
422422

423423
// Verify
424424
@SuppressWarnings("unchecked")
425-
Map<String, String> storedHeaders = threadContext.getTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
425+
Map<String, String> storedHeaders = threadContext
426+
.getTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
426427
assertNotNull(storedHeaders);
427428
assertEquals(4, storedHeaders.size());
428429
assertEquals("access-key-value", storedHeaders.get("x-amzn-fas-accesskey"));
@@ -450,7 +451,8 @@ public void testStoreMcpRequestHeaders_withNoHeaders() {
450451

451452
// Verify - should not store anything in ThreadContext
452453
@SuppressWarnings("unchecked")
453-
Map<String, String> storedHeaders = threadContext.getTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
454+
Map<String, String> storedHeaders = threadContext
455+
.getTransient(org.opensearch.ml.common.CommonValue.MCP_REQUEST_HEADERS_THREAD_CONTEXT_KEY);
454456
assertNull(storedHeaders);
455457
}
456458

0 commit comments

Comments
 (0)