Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve test coverage for MLEngine Class #1376

Open
dhrubo-os opened this issue Sep 25, 2023 · 6 comments · May be fixed by #3675
Open

[FEATURE] Improve test coverage for MLEngine Class #1376

dhrubo-os opened this issue Sep 25, 2023 · 6 comments · May be fixed by #3675
Assignees
@akolarkunnu
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Sep 25, 2023 •
edited
Loading

We need to improve test coverage in our repo.

This issue will target only to improve test coverage for MLEngine.java class

From this url we can see where test coverage is missing for this class: https://app.codecov.io/gh/opensearch-project/ml-commons/blob/2.x/ml-algorithms%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch%2Fml%2Fengine%2FMLEngine.java
@dhrubo-os dhrubo-os added enhancement New feature or request untriaged good first issue Good for newcomers and removed untriaged labels Sep 25, 2023
@MyrtleTurtle22
Copy link

Hi, I'd like to contribute to this but I'm not sure how to start. Could you help me get started?

@divitr divitr mentioned this issue Oct 23, 2023
Closed
5 tasks
@dhrubo-os
Copy link
Collaborator Author

@divitr Looks like you are working on this issue. I'm assigning it to you.

@dhrubo-os
Copy link
Collaborator Author

@divitr could you please comment on this issue? Otherwise I can't assign it to you.

@divitr
Copy link
Contributor

divitr commented Oct 23, 2023

Sure!

@akolarkunnu
Copy link
Contributor

@dhrubo-os Can you please assign this to me, I will work on this.

@dhrubo-os
Copy link
Collaborator Author

Sure, thanks for looking at it.

@dhrubo-os dhrubo-os assigned akolarkunnu and unassigned divitr Mar 13, 2025
akolarkunnu added a commit to akolarkunnu/ml-commons that referenced this issue Mar 19, 2025
@akolarkunnu
[FEATURE] Improve test coverage for MLEngine Class
3648777 
Improved the test coverage by adding missed use cases.
There is no zero argument constructor, constructor with Input as paremeter and constructor with MLAlgoParams.class as paremeter in the class class org.opensearch.ml.engine.algorithms.metrics_correlation.MetricsCorrelation. So it is impossible to cover remianing potions, it always throws java.lang.NoSuchMethodException: org.opensearch.ml.engine.algorithms.metrics_correlation.MetricsCorrelation.<init>().

Resolves opensearch-project#1376

Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
@akolarkunnu akolarkunnu linked a pull request Mar 19, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akolarkunnu akolarkunnu

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
4 participants
@akolarkunnu @divitr @MyrtleTurtle22 @dhrubo-os