upgrade dependencies to make it compatible with AD #4412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie <[email protected]>
jackiehanyang
requested review from
HenryL27,
Zhangxunmt,
austintlee,
b4sjoo,
dhrubo-os,
jngz-es,
mingshl,
model-collapse,
pyek-bot,
rbhavna,
sam-herman,
xinyual,
ylwu-amzn and
zane-neo
as code owners
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Error
jackiehanyang
had a problem deploying
to
ml-commons-cicd-env-require-approval
GitHub Actions
Failure
dhrubo-os
reviewed
Nov 11, 2025
| configurations.all { | ||
| // Force spotless depending on newer version of guava due to CVE-2023-2976. Remove after spotless upgrades. | ||
| resolutionStrategy.force "com.google.guava:guava:32.1.3-jre" | ||
| resolutionStrategy.force "com.google.guava:guava:33.4.5-jre" |
Collaborator
There was a problem hiding this comment.
May be both plugins can take version from core: https://github.com/opensearch-project/OpenSearch/blob/main/gradle/libs.versions.toml#L23 ?
Collaborator
Author
There was a problem hiding this comment.
No, AD needs it for a resource permission related change from security plugin side - opensearch-project/anomaly-detection@ee8e38d They are planning to make this change for all plugins just AD is the first one onboarded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In AD Detection Insights feature, we're calling ml-commons metrics correlation algorithm from AD which adds ml-commons as a runtime dependency. So making some dependency updates to make AD and ml-commons run in the same JVM runtime inside that container and communicate via transport actions.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.