-
Notifications
You must be signed in to change notification settings - Fork 89
Refactor hybrid query pagination logic #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@martin-gaievski I tried to fit all the minclustercheck and isnull check of doXContent method under one but it breaks bwc in the edge cases. |
I did extensive testing and concluded that it is better now compared to one method for all conditions. Regarding your concern of people making the change unknowingly, we can add comments and also we are following the same pattern of put checks in StreamInput, StreamOutput and fromXContent. It won't be an issue. |
can you be more specific, what is the edge case that you couldn't handle properly in your local change? I don't think such code is not possible, it can be not the best from implementation or code organization point of view. You can do draft PR, this will make discussion more productive |
@vibrantvarun Could you elaborate more? Especially for Also, what is not consistent with pagination? |
I think we are good now and don't need to do anything more here. |
Refactor hybrid query pagination logic to be consistent.
The text was updated successfully, but these errors were encountered: