Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Possible breaking change in the text-embedding processor #1243

Open
Zhangxunmt opened this issue Mar 21, 2025 · 1 comment
Open

[BUG] Possible breaking change in the text-embedding processor #1243

Zhangxunmt opened this issue Mar 21, 2025 · 1 comment
Labels
bug Something isn't working untriaged

Comments

@Zhangxunmt
Copy link

What is the bug?

opensearch-project/ml-commons#3677. Following this public tutorial https://opensearch.org/docs/2.17/ml-commons-plugin/tutorials/generate-embeddings/, you will get response like the below. However, the title_embedding should be inside each element of the books. It's verified in OS2.17/2.19 versions that ml-commons both returned embeddings for the model prediction results. From the response of the ingest pipeline, it's likely that the text-embedding has a breaking change after OS version 2.15.

{
  "docs": [
    {
      "doc": {
        "_index": "my_books",
        "_id": "1",
        "_source": {
          "_ingest": {
            "_value": {
              "title_embedding": [
                0.009794682,
                0.04060341,
                0.016146386,
                ...
                -0.03778624
              ]
            }
          },
          "books": [
            {
              "title": "first book",
              "description": "This is first book"
            },
            {
              "title": "second book",
              "description": "This is second book"
            }
          ]
        },
        "_ingest": {
          "_value": null,
          "timestamp": "2025-03-14T22:02:43.240620757Z"
        }
      }
    }
  ]
}

How can one reproduce the bug?

Steps to reproduce the behavior.

What is the expected behavior?

A clear and concise description of what you expected to happen.

What is your host/environment?

Operating system, version.

Do you have any screenshots?

If applicable, add screenshots to help explain your problem.

Do you have any additional context?

Add any other context about the problem.

@Zhangxunmt Zhangxunmt added bug Something isn't working untriaged labels Mar 21, 2025
@will-hwang
Copy link
Contributor

should be fixed with #1204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

2 participants