Fix aggregate reading a TestRun attribute that does not exist (#1097)

Signed-off-by: Serhiy Bzhezytskyy <me@serhiy-bzhezytskyy.com>

Author: serhiy-bzhezytskyy

osbenchmark/aggregator.py

@@ -166,7 +166,7 @@ def update_config_object(self, test_run: TestRun) -> None:
         self.config.add(config.Scope.applicationOverride, "test_run", "pipeline", test_run.pipeline)
         self.config.add(config.Scope.applicationOverride, "workload", "params", test_run.workload_params)
         self.config.add(config.Scope.applicationOverride, "builder",
-                        "cluster_config.params", test_run.cluster_config_instance_params)
+                        "cluster_config.params", test_run.cluster_config_params)
         self.config.add(config.Scope.applicationOverride, "builder", "plugin.params", test_run.plugin_params)
         self.config.add(config.Scope.applicationOverride, "workload", "latency.percentiles", test_run.latency_percentiles)
         self.config.add(config.Scope.applicationOverride, "workload", "throughput.percentiles", test_run.throughput_percentiles)

tests/aggregator_test.py

@@ -1,6 +1,7 @@
 from unittest.mock import Mock
 import pytest
 from osbenchmark import config
+from osbenchmark import metrics
 from osbenchmark.aggregator import Aggregator, AggregatedResults
 
 @pytest.fixture
@@ -120,6 +121,21 @@ def test_calculate_weighted_average(aggregator):
     assert result["latency"]["avg"] == 16  # (10*2 + 20*3) / (2+3)
     assert result["latency"]["unit"] == "ms"
 
+def test_update_config_object_reads_attributes_that_test_runs_actually_have(aggregator):
+    # a real TestRun, not a Mock: a Mock creates whatever attribute is asked of it, so it cannot
+    # tell us whether update_config_object reads attributes that a test run really carries
+    test_run = metrics.TestRun(
+        benchmark_version="1.0.0", benchmark_revision="abc123", environment_name="unit-test",
+        test_run_id="test1", test_run_timestamp="20250101T000000Z", pipeline="benchmark-only",
+        user_tags={}, workload="workload1", workload_params={}, test_procedure="test_proc1",
+        cluster_config=["external"], cluster_config_params={"heap_size": "6g"}, plugin_params={},
+        meta_data={})
+
+    aggregator.update_config_object(test_run)
+
+    aggregator.config.add.assert_any_call(config.Scope.applicationOverride, "builder",
+                                          "cluster_config.params", {"heap_size": "6g"})
+
 def test_calculate_rsd(aggregator):
     values = [1, 2, 3, 4, 5]
     rsd = aggregator.calculate_rsd(values, "test_metric")