Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release]: python ML library opensearch-py-ml #2814

Closed
ylwu-amzn opened this issue Oct 27, 2022 · 10 comments
Closed

[release]: python ML library opensearch-py-ml #2814

ylwu-amzn opened this issue Oct 27, 2022 · 10 comments
Assignees
Labels

Comments

@ylwu-amzn
Copy link
Contributor

What is the name of your component?

opensearch-py-ml

What is the link to your GitHub repo?

https://github.com/opensearch-project/opensearch-py-ml

Targeted release date

Nov 15

Where should we publish this component?

pypi

What type of artifact(s) will be generated for this component?

python library

Have you completed the required reviews including security reviews, UX reviews?

Security review will be done by Nov 12.

Have you on-boarded automated security scanning for the GitHub repo associated with this component?

Yes

Additional context

No response

@ylwu-amzn ylwu-amzn added release untriaged Issues that have not yet been triaged labels Oct 27, 2022
@gaiksaya
Copy link
Member

gaiksaya commented Oct 27, 2022

We are in process of automating releases so it might fall under publishToPyPi library here #2505

@ylwu-amzn
Copy link
Contributor Author

ylwu-amzn commented Oct 27, 2022

We are in process of automating releases so it might fall under publishToPyPi library here #2505

Cool, thanks a lot. any work we need do from our side to onboard this auto release workflow? I see the issue #2505 is open. Is the auto release workflow ready now?

@ylwu-amzn
Copy link
Contributor Author

@bbarani @gaiksaya For this question "Have you completed the required reviews including security reviews, UX reviews?
", we are working with security team for security review now. Should we also ask UX team to review considering this a python library?

@gaiksaya
Copy link
Member

gaiksaya commented Oct 27, 2022

AFAIK, that is for front end components (if any). @bbarani please correct if I am wrong.

@bbarani
Copy link
Member

bbarani commented Oct 28, 2022

I don’t think we need a UX review unless this library has UI. Please update us once the security review is completed CC: @CEHENKLE @elfisher

@dhrubo-os
Copy link

dhrubo-os commented Oct 28, 2022

@bbarani Thanks for your answer. I have 2 follow up questions:

  1. For this library, Security review will be done by 11/12/2022 (ETA given by the reviewer). Will that be a blocker for opensearch-py-ml 2.4 release?
  2. Is this issue mandatory for 2.4 release? As this library is also a client plugin we're going to face the same issue.

@bbarani
Copy link
Member

bbarani commented Nov 1, 2022

Hello @dhrubo-os @ylwu-amzn Does this have to be released along with OpenSearch 2.4 release? As per my understanding, this is a standalone library and can be released independent of 2.4 release. Please let us know if this has to be released on specific time coinciding with any other release.

@dhrubo-os
Copy link

Hi @bbarani Yeah this is a standalone library and can be release independent of 2.4 release. That being said, this plugin will help customer to simplify of few steps in mlCommons custom model feature, which is why we want to release this plugin asap.

Please suggest what are the steps are remaining from our end to release this plugin.

Thanks
Dhrubo

@gaiksaya
Copy link
Member

gaiksaya commented Nov 1, 2022

Hi @dhrubo-os,
I'll update the issue if anything is required from your end.

For now below are the to-do on our list:

  1. Get the fix in for Fix file extension of signature files in signer workflow. #368 as .asc signature is required to sign the packages to PyPi
  2. Create the PublishToPyPi jenkins library Create publishToPyPi #2839
  3. Create automation in opensearch-py-ml repo that includes creating a release-drafter workflow, similar to https://github.com/opensearch-project/opensearch-js/blob/main/.github/workflows/release-drafter.yml
  4. Set up webhook, secrets and other manual set up so that the jenkins workflow is triggered.

@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Nov 1, 2022
@gaiksaya gaiksaya self-assigned this Nov 21, 2022
@gaiksaya
Copy link
Member

gaiksaya commented Dec 1, 2022

The release was successful. Get the artifacts here: https://pypi.org/project/opensearch-py-ml/

@gaiksaya gaiksaya closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants