Skip to content

Commit d13a89c

Browse files
committed
Fix pattern replace by making flag optional as on api
Signed-off-by: Grouh <[email protected]>
1 parent 8513615 commit d13a89c

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

java-client/src/main/java/org/opensearch/client/opensearch/_types/analysis/PatternReplaceCharFilter.java

+13-6
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
import jakarta.json.stream.JsonGenerator;
3636
import java.util.function.Function;
37+
import javax.annotation.Nullable;
3738
import org.opensearch.client.json.JsonpDeserializable;
3839
import org.opensearch.client.json.JsonpDeserializer;
3940
import org.opensearch.client.json.JsonpMapper;
@@ -46,6 +47,7 @@
4647

4748
@JsonpDeserializable
4849
public class PatternReplaceCharFilter extends CharFilterBase implements CharFilterDefinitionVariant {
50+
@Nullable
4951
private final String flags;
5052

5153
private final String pattern;
@@ -57,7 +59,7 @@ public class PatternReplaceCharFilter extends CharFilterBase implements CharFilt
5759
private PatternReplaceCharFilter(Builder builder) {
5860
super(builder);
5961

60-
this.flags = ApiTypeHelper.requireNonNull(builder.flags, this, "flags");
62+
this.flags = builder.flags;
6163
this.pattern = ApiTypeHelper.requireNonNull(builder.pattern, this, "pattern");
6264
this.replacement = ApiTypeHelper.requireNonNull(builder.replacement, this, "replacement");
6365

@@ -76,8 +78,9 @@ public CharFilterDefinition.Kind _charFilterDefinitionKind() {
7678
}
7779

7880
/**
79-
* Required - API name: {@code flags}
81+
* API name: {@code flags}
8082
*/
83+
@Nullable
8184
public final String flags() {
8285
return this.flags;
8386
}
@@ -100,8 +103,11 @@ protected void serializeInternal(JsonGenerator generator, JsonpMapper mapper) {
100103

101104
generator.write("type", "pattern_replace");
102105
super.serializeInternal(generator, mapper);
103-
generator.writeKey("flags");
104-
generator.write(this.flags);
106+
107+
if (this.flags != null) {
108+
generator.writeKey("flags");
109+
generator.write(this.flags);
110+
}
105111

106112
generator.writeKey("pattern");
107113
generator.write(this.pattern);
@@ -118,16 +124,17 @@ protected void serializeInternal(JsonGenerator generator, JsonpMapper mapper) {
118124
*/
119125

120126
public static class Builder extends CharFilterBase.AbstractBuilder<Builder> implements ObjectBuilder<PatternReplaceCharFilter> {
127+
@Nullable
121128
private String flags;
122129

123130
private String pattern;
124131

125132
private String replacement;
126133

127134
/**
128-
* Required - API name: {@code flags}
135+
* API name: {@code flags}
129136
*/
130-
public final Builder flags(String value) {
137+
public final Builder flags(@Nullable String value) {
131138
this.flags = value;
132139
return this;
133140
}

0 commit comments

Comments
 (0)