Skip to content

Commit c9b50b2

Browse files
authored
Replace array by iterable in return type. Fix #307 (#308)
* Replace array by iterable in return type. Fix #307 Signed-off-by: Romain Ruaud <[email protected]> * chore: update changelog according to latest PR Signed-off-by: Romain Ruaud <[email protected]> --------- Signed-off-by: Romain Ruaud <[email protected]>
1 parent 7ddad3d commit c9b50b2

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
99
### Deprecated
1010
### Removed
1111
### Fixed
12+
- Fixed mismatch in return types between `Client::performRequest()` and `Transport::sendRequest()` ([#307](https://github.com/opensearch-project/opensearch-php/issues/307))
1213
### Security
1314
### Updated APIs
1415
- Updated opensearch-php APIs to reflect [opensearch-api-specification@5ed668d](https://github.com/opensearch-project/opensearch-api-specification/commit/5ed668d81b34ae90c22a605755fe1c340f38c27d)

src/OpenSearch/Client.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -2169,7 +2169,7 @@ public function request(
21692169
* @throws \Psr\Http\Client\ClientExceptionInterface
21702170
* @throws \OpenSearch\Exception\HttpExceptionInterface
21712171
*/
2172-
private function performRequest(AbstractEndpoint $endpoint): array|string|null
2172+
private function performRequest(AbstractEndpoint $endpoint): iterable|string|null
21732173
{
21742174
return $this->httpTransport->sendRequest(
21752175
$endpoint->getMethod(),

0 commit comments

Comments
 (0)