Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Broken contracts after upgrading from 2.3.x to 2.4.x #309

Open
kamil-falgowski-tg opened this issue Feb 24, 2025 · 1 comment
Open
Labels
bug Something isn't working

Comments

@kamil-falgowski-tg
Copy link

What is the bug?

OpenSearch\Common\Exceptions namespace is now marked as deprecated, but they are not thrown at all. OpenSearch\Exception are thrown instead.
It breaks the contract in the minor release of the library and should be a part of the major release. First, deprecate then remove in the upcoming major release.

How can one reproduce the bug?

Catch errors thrown by the 2.3.x release and then upgrade to 2.4.x

What is the expected behavior?

OpenSearch\Common\Exceptions should still be used and removed in the 3.0 release

@kamil-falgowski-tg kamil-falgowski-tg added bug Something isn't working untriaged labels Feb 24, 2025
@kimpepper
Copy link
Collaborator

We've tried to keep legacy code throwing the legacy exceptions. For clients created using ClientBuilder, Transport and Connection objects, they should throw the same exceptions as per 2.3.x.

Let us know if you have specific examples which are causing you problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants