Skip to content

[BUG] Footer is not consistent between pages. #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaimmej opened this issue Jun 28, 2024 · 2 comments
Closed

[BUG] Footer is not consistent between pages. #3035

kaimmej opened this issue Jun 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kaimmej
Copy link
Contributor

kaimmej commented Jun 28, 2024

Describe the bug

blog's footer mentions Elasticsearch
https://opensearch.org/blog/
image

Normal footer does not
image

This is coming from _includes/footer_legal.html
line 2 has a templating script that checks whether a variable "notice" is set to true. And if so, we display the Elasticsearch disclaimer.
image

Expected behavior

Should this be here? I do not know.
Why are we applying it to the blog page and not to other pages?

Screenshots

No response

To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@kaimmej kaimmej added bug Something isn't working untriaged labels Jun 28, 2024
@nateynateynate nateynateynate moved this to 🏗 In progress in Website Update Project Jul 12, 2024
@nateynateynate nateynateynate moved this from 🏗 In progress to 📋 Backlog in Website Update Project Jul 12, 2024
@nateynateynate
Copy link
Member

We'll be spec'ing out a new footer. Let's not forget the content here.

@nateynateynate nateynateynate moved this from 📋 Backlog to 🏗 In progress in Website Update Project Jul 19, 2024
@kaimmej kaimmej mentioned this issue Aug 8, 2024
1 task
@nateynateynate
Copy link
Member

Solved by #3157

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Website Update Project Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants