Skip to content

[Refactor] Refactor authentication_type implementation to improve the efficiency to get cookie #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoguan1990 opened this issue Oct 27, 2022 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed, need help from community Refactoring triaged

Comments

@aoguan1990
Copy link
Contributor

aoguan1990 commented Oct 27, 2022

Is your feature request related to a problem?
Cookie is queried by API multiple times in authentication_type. Refactor is needed for abstract methods in authentication_type to improve the efficiency to get cookie.
async getAdditionalAuthHeader( request: OpenSearchDashboardsRequest<unknown, unknown, unknown, any> ): Promise<any> {......
// To Do: refactor this method to improve the efficiency to get cookie, get cookie from input parameter......}

What solution would you like?
Refactor the implementations for abstract methods of AuthenticationType to improve the efficiency to get cookie. Instead of getting cookie for every methods, pass cookie as input parameter to the method.

What alternatives have you considered?
N/A

Do you have any additional context?
Request coming from a PR review comment: #1110 (comment)

@cwperks
Copy link
Member

cwperks commented Oct 31, 2022

[Triage] @aoguan1990 Could you please use the issue template (https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/ISSUE_TEMPLATE/bug_report.md)? We're interested in learning more about what completion of this issue entails.

@cwperks
Copy link
Member

cwperks commented Nov 7, 2022

[Triage follow-up] Waiting for more details

@aoguan1990
Copy link
Contributor Author

[Triage] @aoguan1990 Could you please use the issue template (https://github.com/opensearch-project/security-dashboards-plugin/blob/main/.github/ISSUE_TEMPLATE/bug_report.md)? We're interested in learning more about what completion of this issue entails.

@cwperks Thank you so much for following up on this issue. Updated the issue with Feature Request template. Please let me know if you have more questions.

@peternied peternied added help wanted Extra attention is needed, need help from community triaged and removed untriaged labels Nov 14, 2022
@peternied
Copy link
Member

[Triage] @aoguan1990 Thanks for updating the description!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed, need help from community Refactoring triaged
Projects
None yet
Development

No branches or pull requests

3 participants