Update default behavior for _cat/indices to return indices visible to requesting user #5196
+193
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requesting user Signed-off-by: Craig Perkins <[email protected]>
cwperks
commented
Mar 21, 2025
| @@ -538,7 +536,8 @@ public PrivilegesEvaluatorResponse evaluate(PrivilegesEvaluationContext context) | |||
| } | |||
| } | |||
|
|
|||
| boolean dnfofPossible = dnfofEnabled && DNFOF_MATCHER.test(action0); | |||
| boolean dnfofPossible = (dnfofEnabled && DNFOF_MATCHER.test(action0)) | |||
| || Set.of("indices:monitor/settings/get", "indices:monitor/stats").contains(action0); | |||
There was a problem hiding this comment.
This should be extracted to a different constant
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5196 +/- ##
==========================================
+ Coverage 71.67% 71.73% +0.05%
==========================================
Files 337 337
Lines 22789 22791 +2
Branches 3606 3606
==========================================
+ Hits 16334 16348 +14
+ Misses 4651 4639 -12
Partials 1804 1804
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR up to show what's required for changing the default behavior of
_cat/indicesso that it always returns a list of the indices that the requesting user has access to.This makes it possible to have roles where the index pattern is scoped down from
*. In the current behavior, this role would always get a forbidden error when calling_cat/indicesunlessdo_not_fail_on_forbiddenis set to true.Enhancement
Issues Resolved
Resolves #5195
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.