Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider default behavior for DNFOF in 3.0.0 #5195

Open
cwperks opened this issue Mar 21, 2025 · 2 comments · May be fixed by #5196
Open

Reconsider default behavior for DNFOF in 3.0.0 #5195

cwperks opened this issue Mar 21, 2025 · 2 comments · May be fixed by #5196
Labels
untriaged Require the attention of the repository maintainers and may need to be prioritized

Comments

@cwperks
Copy link
Member

cwperks commented Mar 21, 2025

Coming from conversation on opensearch-project/OpenSearch#17650

When a user is mapped to a role that has full access to a subset of indices in a cluster then by default _cat/indices will fail with a Forbidden error instead of returning the indices that are visible to the user. As a workaround, we instruct cluster administrators to consider toggling do_not_fail_on_forbidden to true.

With this issue, I propose changing the default behavior (at least for _cat/indices) to always return the indices visible to the user regardless if a cluster has DNFOF set to true.

I believe this is possible by updating this line to return true if the action is indices:monitor/settings/get

What do the maintainers think of this change in default behavior for 3.0.0 release?

@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label Mar 21, 2025
@nibix
Copy link
Collaborator

nibix commented Mar 21, 2025

Answering your question from opensearch-project/OpenSearch#17650 (comment) here:

I do believe that when using Dashboards one should have DNFOF enabled, yes.

Still, DNFOF has design flaws. Thus, I am not sure if having it enabled always makes sense.

Actually, I wrote down an RFC on DNFOF a while ago:

#3905

@cwperks
Copy link
Member Author

cwperks commented Mar 21, 2025

Actually, I wrote down an RFC on DNFOF a while ago:

#3905

This would be a good change. I think this would be a good improvement to the system that reduces the level of complexity in grokking how security works in opensearch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Require the attention of the repository maintainers and may need to be prioritized
Projects
None yet
2 participants