Skip to content

Commit 0e91b2e

Browse files
committed
Merge branch 'main' into feature/json-extract
Signed-off-by: Kenrick Yap <[email protected]> # Conflicts: # core/src/main/java/org/opensearch/sql/expression/DSL.java # core/src/main/java/org/opensearch/sql/expression/function/BuiltinFunctionName.java # core/src/main/java/org/opensearch/sql/expression/json/JsonFunctions.java # core/src/main/java/org/opensearch/sql/utils/JsonUtils.java # core/src/test/java/org/opensearch/sql/expression/json/JsonFunctionsTest.java # docs/user/ppl/functions/json.rst # doctest/test_data/json_test.json # integ-test/src/test/java/org/opensearch/sql/ppl/JsonFunctionsIT.java # integ-test/src/test/resources/json_test.json # ppl/src/main/antlr/OpenSearchPPLLexer.g4
2 parents afb385f + becf303 commit 0e91b2e

File tree

6 files changed

+8
-12
lines changed

6 files changed

+8
-12
lines changed

core/src/test/java/org/opensearch/sql/expression/json/JsonFunctionsTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import static org.junit.jupiter.api.Assertions.assertEquals;
99
import static org.junit.jupiter.api.Assertions.assertThrows;
1010
import static org.junit.jupiter.api.Assertions.assertTrue;
11+
1112
import static org.opensearch.sql.data.model.ExprValueUtils.LITERAL_FALSE;
1213
import static org.opensearch.sql.data.model.ExprValueUtils.LITERAL_MISSING;
1314
import static org.opensearch.sql.data.model.ExprValueUtils.LITERAL_NULL;

docs/user/ppl/functions/json.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ JSON_VALID
1414
Description
1515
>>>>>>>>>>>
1616

17-
Usage: `json_valid(json_string)` checks if `json_string` is a valid STRING string.
17+
Usage: `json_valid(json_string)` checks if `json_string` is a valid JSON-encoded string.
1818

1919
Argument type: STRING
2020

@@ -23,7 +23,7 @@ Return type: BOOLEAN
2323
Example::
2424

2525
> source=json_test | eval is_valid = json_valid(json_string) | fields test_name, json_string, is_valid
26-
fetched rows / total rows = 6/6
26+
fetched rows / total rows = 7/7
2727
+---------------------+-------------------------------------+----------+
2828
| test_name | json_string | is_valid |
2929
|---------------------|-------------------------------------|----------|

integ-test/build.gradle

+4-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ apply plugin: 'java'
4444
apply plugin: 'io.freefair.lombok'
4545
apply plugin: 'com.wiredforcode.spawn'
4646

47-
String baseVersion = "2.17.0"
47+
// The next major version is only API compat w/ the last minor of the previous major.
48+
// baseVersion need to roll-froward accordingly, as new 2.x of OpenSearch being released.
49+
// See: https://github.com/opensearch-project/OpenSearch/issues/3615
50+
String baseVersion = "2.19.0"
4851
String bwcVersion = baseVersion + ".0";
4952
String baseName = "sqlBwcCluster"
5053
String bwcFilePath = "src/test/resources/bwc/"

ppl/src/main/antlr/OpenSearchPPLLexer.g4

-4
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,6 @@ FIRST: 'FIRST';
202202
LAST: 'LAST';
203203
LIST: 'LIST';
204204
VALUES: 'VALUES';
205-
EARLIEST: 'EARLIEST';
206-
EARLIEST_TIME: 'EARLIEST_TIME';
207-
LATEST: 'LATEST';
208-
LATEST_TIME: 'LATEST_TIME';
209205
PER_DAY: 'PER_DAY';
210206
PER_HOUR: 'PER_HOUR';
211207
PER_MINUTE: 'PER_MINUTE';

ppl/src/main/antlr/OpenSearchPPLParser.g4

-4
Original file line numberDiff line numberDiff line change
@@ -959,10 +959,6 @@ keywordsCanBeId
959959
| LAST
960960
| LIST
961961
| VALUES
962-
| EARLIEST
963-
| EARLIEST_TIME
964-
| LATEST
965-
| LATEST_TIME
966962
| PER_DAY
967963
| PER_HOUR
968964
| PER_MINUTE

release-notes/opendistro-for-elasticsearch-sql.release-notes-1.6.0.0.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@
2323
### Bugfixes
2424
* Bugfix [#310](https://github.com/opendistro-for-elasticsearch/sql/pull/310): Add DATETIME cast support (issue: [#268](https://github.com/opendistro-for-elasticsearch/sql/issues/268))
2525
* BugFix [#365](https://github.com/opendistro-for-elasticsearch/sql/pull/365): Return Correct Type Information for Fields (issue: [#316](https://github.com/opendistro-for-elasticsearch/sql/issues/316))
26-
* BugFix [#377](https://github.com/opendistro-for-elasticsearch/sql/pull/377): Return object type for field which has implicit object datatype when describe the table (issue:[sql-jdbc#57](https://github.com/opendistro-for-elasticsearch/sql-jdbc/issues/57))
26+
* BugFix [#377](https://github.com/opendistro-for-elasticsearch/sql/pull/377): Return object type for field which has implicit object datatype when describe the table (issue:[sql-jdbc#57](https://github.com/amazon-archives/sql-jdbc/issues/57))
2727
* BugFix [#381](https://github.com/opendistro-for-elasticsearch/sql/pull/381): FIX field function name letter case preserved in select with group by (issue: [#373](https://github.com/opendistro-for-elasticsearch/sql/issues/373))

0 commit comments

Comments
 (0)