Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Calcite Engine Framework: Support TINYINT/SMALLINT/INT/BIGINT type #3348

Closed
LantaoJin opened this issue Feb 25, 2025 · 3 comments
Closed
Assignees
Labels
calcite calcite migration releated feature

Comments

@LantaoJin
Copy link
Member

Is your feature request related to a problem?
In 3.0.0, we will unified the PPL data types.

What solution would you like?
Introduce the replacement data types as follow.

OpenSearch PPL Data Type Spark PPL Data Type Unified PPL Data Type
byte tinyint tinyint
short smallint smallint
integer int int
long bigint bigint

Ref #3339

@LantaoJin LantaoJin added calcite calcite migration releated feature labels Feb 25, 2025
@LantaoJin LantaoJin changed the title [FEATURE] Calcite Engine Framework: Support TININT/SMALLINT/INT/BIGINT type [FEATURE] Calcite Engine Framework: Support TINYINT/SMALLINT/INT/BIGINT type Feb 25, 2025
@LantaoJin
Copy link
Member Author

May no change required after #3339 completed, just open this for tracking.

@Swiddis
Copy link
Collaborator

Swiddis commented Feb 25, 2025

Is this resolved by #3342? I see in the diff that it features changes to the OpenSearchTypeFactory.

@LantaoJin
Copy link
Member Author

LantaoJin commented Feb 26, 2025

Is this resolved by #3342? I see in the diff that it features changes to the OpenSearchTypeFactory.

Yes.

public static RelDataType convertExprTypeToRelDataType(ExprType fieldType, boolean nullable) {
is a convertor to convert PPL data type to Calcite Data type. So I think there is no additional effort to support TINYINT/SMALLINT/INT/BIGINT. But we may add more tests to close this issue.

@LantaoJin LantaoJin self-assigned this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calcite calcite migration releated feature
Projects
None yet
Development

No branches or pull requests

3 participants