Resolving lint issues on scaleup and upgrade playbooks

Author: jstuever

playbooks/scaleup.yml

@@ -4,18 +4,18 @@
   connection: local
   gather_facts: no
   tasks:
-  - import_role:
-      name: openshift_node
-      tasks_from: scaleup_checks.yml
+    - import_role:
+        name: openshift_node
+        tasks_from: scaleup_checks.yml
 
 - name: Pre-scaleup checks
   hosts: new_workers
   tasks:
-  - import_role:
-      name: openshift_node
-      tasks_from: version_checks.yml
+    - import_role:
+        name: openshift_node
+        tasks_from: version_checks.yml
 
 - name: install nodes
   hosts: new_workers
   roles:
-  - openshift_node
+    - openshift_node

playbooks/upgrade.yml

@@ -4,24 +4,24 @@
   connection: local
   gather_facts: no
   tasks:
-  - name: Ensure [workers] group is populated
-    fail:
-      msg: >
-        Detected no workers in inventory. Please add hosts to the
-        workers host group to upgrade nodes
-    when: groups.workers | default([]) | length == 0
+    - name: Ensure [workers] group is populated
+      fail:
+        msg: >
+          Detected no workers in inventory. Please add hosts to the
+          workers host group to upgrade nodes
+      when: groups.workers | default([]) | length == 0
 
 - name: Pre-upgrade checks
   hosts: workers
   tasks:
-  - import_role:
-      name: openshift_node
-      tasks_from: version_checks.yml
+    - import_role:
+        name: openshift_node
+        tasks_from: version_checks.yml
 
 - name: upgrade nodes
   hosts: workers
   serial: 1
   tasks:
-  - import_role:
-      name: openshift_node
-      tasks_from: upgrade.yml
+    - import_role:
+        name: openshift_node
+        tasks_from: upgrade.yml

roles/openshift_node/tasks/version_checks.yml

@@ -20,6 +20,6 @@
   fail:
     msg: "As of v4.10, RHEL nodes must be at least version 8.4"
   when:
-    - l_cluster_version is version('4.10', '>=')
-    - ansible_facts['distribution'] == "RedHat"
-    - ansible_facts['distribution_version'] is version('8.4', '<')
+  - l_cluster_version is version('4.10', '>=')
+  - ansible_facts['distribution'] == "RedHat"
+  - ansible_facts['distribution_version'] is version('8.4', '<')