packages-openshift: define repos list there

Previously, when building the layered node image, we were relying on the
default repo enablement settings. This though is at the source of a lot
of complexity because then we need to make sure that we only inject just
the repos that we need with the right enablement. See e.g. the complex
logic in `get-ocp-repo.sh`.

Let's instead match the semantics already in use by the base compose and
extensions builds, both of which explicitly list the repos to enable.
This means that we can be a lot less careful in what repo definitions we
inject into the build environment, knowing only the necessary ones will
be enabled.

This is pretty easy to do now that (1) rpm-ostree suppports inlined
treefiles, and (2) `treefile-apply` supports a `--var` option to define
variables at invocation time.

Author: jlebon

Containerfile

@@ -47,9 +47,10 @@ fi
 # https://github.com/CentOS/centos-bootc/issues/393
 mkdir -p /var/opt
 
+source /etc/os-release
 # this is where all the real work happens
 rpm-ostree experimental compose treefile-apply \
-  /run/src/packages-openshift.yaml
+  --var id=$ID /run/src/packages-openshift.yaml
 
 # do any cleanups necessary to undo what `get-ocp-repo.sh` did
 if [ "${OPENSHIFT_CI}" != 0 ]; then

manifest-c9s.yaml

@@ -6,6 +6,7 @@ metadata:
   summary: CentOS Stream CoreOS 9
 
 variables:
+  id: "centos"
   osversion: "c9s"
   inherit_tier_x: true
 

manifest-rhel-9.6.yaml

@@ -6,6 +6,7 @@ metadata:
   summary: RHEL CoreOS 9.6
 
 variables:
+  id: "rhel"
   osversion: "rhel-9.6"
   inherit_tier_x: true
 

packages-openshift.yaml

@@ -4,6 +4,24 @@ metadata:
   # inject when building the layered image.
   ocp_version: "4.19"
 
+conditional-include:
+  - if: id == "rhel"
+    include:
+      repos:
+        - rhel-9.6-baseos
+        - rhel-9.6-appstream
+        - rhel-9.6-early-kernel
+        - rhel-9.6-fast-datapath
+        - rhel-9.6-server-ose-4.19
+  - if: id == "centos"
+    include:
+      repos:
+        - c9s-baseos
+        - c9s-appstream
+        - c9s-sig-nfv
+        - c9s-sig-cloud-okd
+        - rhel-9.6-server-ose-4.19
+
 packages:
   # The packages below are required by OpenShift/OKD
   # but are not present in CentOS Stream and RHEL.