Fix stale SecretHashes on nodeset status after node removal

When a node is removed from a nodeset and a full deployment
(no ServicesOverride) succeeds, overwrite the nodeset's
SecretHashes with the deployment's hashes instead of merging.
This drops stale TLS cert secret hash entries for the removed
node. Partial deployments (with ServicesOverride) continue to
merge additively to preserve hashes from other deployments.

Change-Id: I12abffa18af63b14630f80f5a0e6235158f4a9ef
Signed-off-by: rabi <ramishra@redhat.com>

Author: rabi

internal/controller/dataplane/openstackdataplanenodeset_controller.go

@@ -592,8 +592,12 @@ func checkDeployment(ctx context.Context, helper *helper.Helper,
 			for k, v := range deployment.Status.ConfigMapHashes {
 				instance.Status.ConfigMapHashes[k] = v
 			}
-			for k, v := range deployment.Status.SecretHashes {
-				instance.Status.SecretHashes[k] = v
+			if len(deployment.Spec.ServicesOverride) == 0 {
+				instance.Status.SecretHashes = deployment.Status.SecretHashes
+			} else {
+				for k, v := range deployment.Status.SecretHashes {
+					instance.Status.SecretHashes[k] = v
+				}
 			}
 			for k, v := range deployment.Status.ContainerImages {
 				instance.Status.ContainerImages[k] = v