Implement messaging bus configuration with migration from deprecated fields

Add top-level MessagingBus and NotificationsBus configuration to
OpenstackControlPlane API to replace service-specific RabbitMQ settings.
This provides a centralized way to configure messaging infrastructure
while maintaining backward compatibility.

API changes:
- Add MessagingBus field for RPC communication configuration (username,
  vhost, cluster)
- Add NotificationsBus field for notifications configuration
- Deprecate NotificationsBusInstance in favor of NotificationsBus.Cluster
- Remove default values for deprecated rabbitMqClusterName fields across
  all service CRDs to enable proper migration

Webhook changes:
- Update ValidateCreate and ValidateUpdate to return warnings in addition
  to errors
- Add centralized validation for deprecated fields with warning messages
- Add ValidateMessagingBusConfig validation
- Update service validation calls to capture warnings from downstream
  operators

Controller changes:
- Add migration logic to automatically populate NotificationsBus.Cluster
  from deprecated NotificationsBusInstance field during reconciliation
- Migration occurs before service reconciliation to ensure services
  inherit migrated values

Service integration:
- Update all service templates (barbican, cinder, designate, glance,
  heat, ironic, keystone, manila, neutron, nova, octavia, swift,
  telemetry, watcher) to support new messaging bus fields
- Services inherit top-level configuration but can override with
  service-specific settings

Testing:
- Add comprehensive migration tests for deprecated field handling
- Add RabbitMQ cascading configuration tests
- Update functional tests for new configuration structure

Additional fixes:
- Fix pin-bundle-images.sh to handle operators with replace directives
  by forcing quay.io for replaced operators and adding fallback logic
  when bundles are not available in custom registries

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: lmiccini

api/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -127,13 +127,27 @@ type OpenStackControlPlaneSpec struct {
 	// Rabbitmq - Parameters related to the Rabbitmq service
 	Rabbitmq RabbitmqSection `json:"rabbitmq,omitempty"`
 
+	// +kubebuilder:validation:Optional
+	// MessagingBus configuration (username, vhost, and cluster) for RPC communication.
+	// This is the default configuration for all services.
+	// Individual services can override by setting their own Template.MessagingBus.
+	MessagingBus *rabbitmqv1.RabbitMqConfig `json:"messagingBus,omitempty"`
+
 	// +kubebuilder:validation:Optional
 	// NotificationsBusInstance - the name of RabbitMQ Cluster CR to select a Messaging
 	// Bus Service instance used by all services that produce or consume notifications.
 	// Avoid colocating it with RabbitMQ services used for PRC.
 	// That instance will be pushed down for services, unless overriden in templates.
+	// Deprecated: Use NotificationsBus.Cluster instead
 	NotificationsBusInstance *string `json:"notificationsBusInstance,omitempty"`
 
+	// +kubebuilder:validation:Optional
+	// NotificationsBus configuration (username, vhost, and cluster) for notifications.
+	// This is the default configuration for all services.
+	// Individual services can override by setting their own Template.NotificationsBus.
+	// Avoid colocating with MessagingBus used for RPC.
+	NotificationsBus *rabbitmqv1.RabbitMqConfig `json:"notificationsBus,omitempty"`
+
 	// +kubebuilder:validation:Optional
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// Memcached - Parameters related to the Memcached service

api/core/v1beta1/openstackcontrolplane_types.go

@@ -0,0 +1,124 @@
+package v1beta1
+
+import (
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	rabbitmqv1 "github.com/openstack-k8s-operators/infra-operator/apis/rabbitmq/v1beta1"
+	"k8s.io/apimachinery/pkg/util/validation/field"
+)
+
+var _ = Describe("OpenStackControlPlane Webhook", func() {
+
+	Context("ValidateMessagingBusConfig", func() {
+		var instance *OpenStackControlPlane
+		var basePath *field.Path
+
+		BeforeEach(func() {
+			instance = &OpenStackControlPlane{
+				Spec: OpenStackControlPlaneSpec{},
+			}
+			basePath = field.NewPath("spec")
+		})
+
+		It("should allow only Cluster field in messagingBus", func() {
+			instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(BeEmpty())
+		})
+
+		It("should allow Cluster and Vhost fields in messagingBus", func() {
+			instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq",
+				Vhost:   "/openstack",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(BeEmpty())
+		})
+
+		It("should reject User field in messagingBus", func() {
+			instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq",
+				User:    "shared-user",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(HaveLen(1))
+			Expect(errs[0].Type).To(Equal(field.ErrorTypeForbidden))
+			Expect(errs[0].Field).To(Equal("spec.messagingBus.user"))
+			Expect(errs[0].Detail).To(ContainSubstring("user field is not allowed at the top level"))
+		})
+
+		It("should reject User field even with other valid fields in messagingBus", func() {
+			instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq",
+				Vhost:   "/openstack",
+				User:    "shared-user",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(HaveLen(1))
+			Expect(errs[0].Type).To(Equal(field.ErrorTypeForbidden))
+			Expect(errs[0].Field).To(Equal("spec.messagingBus.user"))
+		})
+
+		It("should allow only Cluster field in notificationsBus", func() {
+			instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq-notifications",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(BeEmpty())
+		})
+
+		It("should allow Cluster and Vhost fields in notificationsBus", func() {
+			instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq-notifications",
+				Vhost:   "/notifications",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(BeEmpty())
+		})
+
+		It("should reject User field in notificationsBus", func() {
+			instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq-notifications",
+				User:    "shared-user",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(HaveLen(1))
+			Expect(errs[0].Type).To(Equal(field.ErrorTypeForbidden))
+			Expect(errs[0].Field).To(Equal("spec.notificationsBus.user"))
+			Expect(errs[0].Detail).To(ContainSubstring("user field is not allowed at the top level"))
+		})
+
+		It("should reject User field in both messagingBus and notificationsBus", func() {
+			instance.Spec.MessagingBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq",
+				User:    "rpc-user",
+			}
+			instance.Spec.NotificationsBus = &rabbitmqv1.RabbitMqConfig{
+				Cluster: "rabbitmq-notifications",
+				User:    "notif-user",
+			}
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(HaveLen(2))
+			Expect(errs[0].Field).To(Equal("spec.messagingBus.user"))
+			Expect(errs[1].Field).To(Equal("spec.notificationsBus.user"))
+		})
+
+		It("should allow nil messagingBus and notificationsBus", func() {
+			instance.Spec.MessagingBus = nil
+			instance.Spec.NotificationsBus = nil
+
+			errs := instance.ValidateMessagingBusConfig(basePath)
+			Expect(errs).To(BeEmpty())
+		})
+	})
+})

api/core/v1beta1/openstackcontrolplane_webhook.go

@@ -5,8 +5,8 @@ go 1.24.4
 require (
 	github.com/cert-manager/cert-manager v1.16.5
 	github.com/go-playground/validator/v10 v10.30.1
-	github.com/onsi/ginkgo/v2 v2.27.5
-	github.com/onsi/gomega v1.39.0
+	github.com/onsi/ginkgo/v2 v2.28.1
+	github.com/onsi/gomega v1.39.1
 	github.com/openstack-k8s-operators/barbican-operator/api v0.6.1-0.20260126155915-bd373daa8e8c
 	github.com/openstack-k8s-operators/cinder-operator/api v0.6.1-0.20260124150910-c004203b9504
 	github.com/openstack-k8s-operators/designate-operator/api v0.6.1-0.20260126110625-223581247a61
@@ -16,8 +16,8 @@ require (
 	github.com/openstack-k8s-operators/infra-operator/apis v0.6.1-0.20260128074606-03b808364e4a
 	github.com/openstack-k8s-operators/ironic-operator/api v0.6.1-0.20260126092810-cd39d45b6c0e
 	github.com/openstack-k8s-operators/keystone-operator/api v0.6.1-0.20260126175636-114b4c65a959
-	github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20260126081203-efc2df9207eb
-	github.com/openstack-k8s-operators/lib-common/modules/storage v0.6.1-0.20260126081203-efc2df9207eb
+	github.com/openstack-k8s-operators/lib-common/modules/common v0.6.1-0.20260128142552-e2c25eccae5a
+	github.com/openstack-k8s-operators/lib-common/modules/storage v0.6.1-0.20260128142552-e2c25eccae5a
 	github.com/openstack-k8s-operators/manila-operator/api v0.6.1-0.20260124125332-5046d6342e48
 	github.com/openstack-k8s-operators/mariadb-operator/api v0.6.1-0.20260127154438-ff95971883bb
 	github.com/openstack-k8s-operators/neutron-operator/api v0.6.1-0.20260128083308-da1a0d762151
@@ -34,7 +34,7 @@ require (
 	go.uber.org/multierr v1.11.0 // indirect
 	go.uber.org/zap v1.27.1 // indirect
 	golang.org/x/exp v0.0.0-20241217172543-b2144cdd0a67
-	golang.org/x/tools v0.40.0 // indirect
+	golang.org/x/tools v0.41.0 // indirect
 	k8s.io/api v0.31.14
 	k8s.io/apimachinery v0.31.14
 	k8s.io/client-go v0.31.14
@@ -66,7 +66,7 @@ require (
 	github.com/google/gnostic-models v0.7.0 // indirect
 	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect
-	github.com/google/pprof v0.0.0-20250403155104-27863c87afa6 // indirect
+	github.com/google/pprof v0.0.0-20260115054156-294ebfa9ad83 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/gophercloud/gophercloud/v2 v2.8.0 // indirect
 	github.com/imdario/mergo v0.3.16 // indirect
@@ -80,7 +80,7 @@ require (
 	github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
 	github.com/openshift/api v3.9.0+incompatible // indirect
-	github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20251230215914-6ba873b49a35 // indirect
+	github.com/openstack-k8s-operators/lib-common/modules/openstack v0.6.1-0.20260126081203-efc2df9207eb // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/prometheus/client_golang v1.22.0 // indirect
 	github.com/prometheus/client_model v0.6.2 // indirect
@@ -92,9 +92,9 @@ require (
 	github.com/x448/float16 v0.8.4 // indirect
 	go.yaml.in/yaml/v2 v2.4.2 // indirect
 	go.yaml.in/yaml/v3 v3.0.4 // indirect
-	golang.org/x/crypto v0.46.0 // indirect
-	golang.org/x/mod v0.31.0 // indirect
-	golang.org/x/net v0.48.0 // indirect
+	golang.org/x/crypto v0.47.0 // indirect
+	golang.org/x/mod v0.32.0 // indirect
+	golang.org/x/net v0.49.0 // indirect
 	golang.org/x/oauth2 v0.30.0 // indirect
 	golang.org/x/sync v0.19.0 // indirect
 	golang.org/x/sys v0.40.0 // indirect
@@ -143,3 +143,31 @@ replace k8s.io/code-generator => k8s.io/code-generator v0.31.14 //allow-merging
 replace k8s.io/component-base => k8s.io/component-base v0.31.14 //allow-merging
 
 replace github.com/cert-manager/cmctl/v2 => github.com/cert-manager/cmctl/v2 v2.1.2-0.20241127223932-88edb96860cf //allow-merging
+
+replace github.com/openstack-k8s-operators/barbican-operator/api => github.com/lmiccini/barbican-operator/api v0.0.0-20260130153748-c0862ee80f6b
+
+replace github.com/openstack-k8s-operators/cinder-operator/api => github.com/lmiccini/cinder-operator/api v0.0.0-20260202135636-cac3f48d9aa2
+
+replace github.com/openstack-k8s-operators/designate-operator/api => github.com/lmiccini/designate-operator/api v0.0.0-20260129195526-07a2bbdbbbc6
+
+replace github.com/openstack-k8s-operators/glance-operator/api => github.com/lmiccini/glance-operator/api v0.0.0-20260204060307-02f38e6051cf
+
+replace github.com/openstack-k8s-operators/heat-operator/api => github.com/lmiccini/heat-operator/api v0.0.0-20260130153836-0162a8fbe588
+
+replace github.com/openstack-k8s-operators/ironic-operator/api => github.com/lmiccini/ironic-operator/api v0.0.0-20260203063324-88bdbd5829f7
+
+replace github.com/openstack-k8s-operators/keystone-operator/api => github.com/lmiccini/keystone-operator/api v0.0.0-20260130154009-73911b575f47
+
+replace github.com/openstack-k8s-operators/manila-operator/api => github.com/lmiccini/manila-operator/api v0.0.0-20260204094838-b0fc51fc62dc
+
+replace github.com/openstack-k8s-operators/neutron-operator/api => github.com/lmiccini/neutron-operator/api v0.0.0-20260130154215-206cdc241686
+
+replace github.com/openstack-k8s-operators/nova-operator/api => github.com/lmiccini/nova-operator/api v0.0.0-20260130154456-145dc1dc3e11
+
+replace github.com/openstack-k8s-operators/octavia-operator/api => github.com/lmiccini/octavia-operator/api v0.0.0-20260131142608-b5b99abd4e39
+
+replace github.com/openstack-k8s-operators/swift-operator/api => github.com/lmiccini/swift-operator/api v0.0.0-20260201083840-dc87b8fbd348
+
+replace github.com/openstack-k8s-operators/telemetry-operator/api => github.com/lmiccini/telemetry-operator/api v0.0.0-20260202133001-8d290e538966
+
+replace github.com/openstack-k8s-operators/watcher-operator/api => github.com/lmiccini/watcher-operator/api v0.0.0-20260130155151-6da48495bd84