Skip to content

Commit 72296db

Browse files
committed
stub review data until FE removes them
1 parent f2053b3 commit 72296db

File tree

4 files changed

+26
-3
lines changed

4 files changed

+26
-3
lines changed

salesforce/management/commands/update_partners.py

-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ def handle(self, *args, **options):
2323
query = "SELECT " \
2424
"Id, " \
2525
"Name, " \
26-
"Logo__c, " \
27-
"Public_Logo_Link__c, " \
2826
"Partner_Type__c, " \
2927
"Books_Offered__c, " \
3028
"Description__c, " \

salesforce/models.py

+13
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,19 @@ def partner_logo_tag(self):
253253
else:
254254
return mark_safe(u'<img src="" />')
255255

256+
# TODO: the next three methods about reviews should be removed once the FE is updated to not expect them
257+
@property
258+
def reviews(self):
259+
return []
260+
261+
@property
262+
def average_rating(self):
263+
return {'rating__avg': 0.0}
264+
265+
@property
266+
def rating_count(self):
267+
return 0
268+
256269
@hooks.register('register_admin_menu_item')
257270
def register_partner_menu_item():
258271
return MenuItem('Partners', '/django-admin/salesforce/partner/', classname='icon icon-group', order=3000)

salesforce/serializers.py

+10
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,11 @@ class Meta:
7777
)
7878

7979
class PartnerSerializer(serializers.ModelSerializer):
80+
# TODO: remove
81+
reviews = serializers.ReadOnlyField()
82+
average_rating = serializers.ReadOnlyField()
83+
rating_count = serializers.ReadOnlyField()
84+
8085
def __init__(self, *args, **kwargs):
8186
super(PartnerSerializer, self).__init__(*args, **kwargs)
8287

@@ -86,6 +91,11 @@ def __init__(self, *args, **kwargs):
8691
def to_representation(self, instance):
8792
ret = super().to_representation(instance)
8893

94+
# TODO: remove
95+
# if looking at an individual partner instance, include the reviews - else, exclude
96+
if not isinstance(self.instance, Partner):
97+
ret['reviews'] = False
98+
8999
# Here we filter the null values and creates a new dictionary
90100
# We use OrderedDict like in original method
91101
ret = OrderedDict(filter(lambda x: x[1] is not False, ret.items()))

salesforce/urls.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111

1212
urlpatterns = [
1313
path('', include(router.urls)),
14-
path('adoption-status/', views.get_adoption_status),
14+
#TODO: remove
15+
path('reviews/', views.AdoptionOpportunityRecordViewSet.as_view({'get': 'list'}),
1516
path('renewal/', views.AdoptionOpportunityRecordViewSet.as_view({'get': 'list'}))
17+
1618
]

0 commit comments

Comments
 (0)